Fix "too many open files" after consecutive runs #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced by PR scala-native#1728. It basically leaves the files open in the VirtualDirectory.read(path, len) method. After 3-4 consecutive runs in sbt, the build would complain with "too many open files", which makes sense since the above method is used to look for classes with entry points, so it is essentially used to open every single .nir file in the build.
sjrd
approved these changes
Jul 8, 2020
|
Thanks, I was seeing that problem pretty often. |
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
This bug was introduced by PR scala-native#1728. It basically leaves the files open in the VirtualDirectory.read(path, len) method. After 3-4 consecutive runs in sbt, the build would complain with "too many open files", which makes sense since the above method is used to look for classes with entry points, so it is essentially used to open every single .nir file in the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced by PR #1728. It basically leaves
the files open in the VirtualDirectory.read(path, len) method.
After 3-4 consecutive runs in sbt, the build would complain with
"too many open files", which makes sense since the above method
is used to look for classes with entry points, so it is essentially
used to open every single .nir file in the build.