Fix #1256: Add JUnit support #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
reviewed
Jul 9, 2020
Co-authored-by: Lorenzo Gabriele <lorenzolespaul@gmail.com>
sjrd
requested changes
Jul 9, 2020
junit-runtime/src/main/scala/org/junit/internal/ArrayComparisonFailure.scala
Outdated
Show resolved
Hide resolved
junit-runtime/src/main/scala/scala/scalanative/junit/Bootstrapper.scala
Outdated
Show resolved
Hide resolved
junit-runtime/src/main/scala/scala/scalanative/junit/JUnitTask.scala
Outdated
Show resolved
Hide resolved
sjrd
requested changes
Jul 9, 2020
junit-test/shared/src/test/scala/scala/scalanative/junit/AsyncTest.scala
Outdated
Show resolved
Hide resolved
junit-async/native/src/main/scala/scala/scalanative/junit/async/package.scala
Outdated
Show resolved
Hide resolved
junit-async/native/src/main/scala/scala/scalanative/junit/async/package.scala
Outdated
Show resolved
Hide resolved
|
I saw a comment about normalized names but I think this takes care of it unless this setting is not used. https://github.com/scala-native/scala-native/blob/master/build.sbt#L23 |
Yep, basically that was the part that introduced the problem. It converts the camelCase name to kebab-case. So, |
sjrd
approved these changes
Jul 9, 2020
|
@errikos Cool, I saw the code after it changed to |
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
Add JUnit support for Scala Native and its projects. See `docs/user/testing.rst` for usage instructions.
The feature was mostly ported from Scala.js, with some adaptations for Scala Native.
### Notes
- The existing Scala Native test runner (`TestMain`) does not support multiple testing frameworks. For that reason, we now spawn one `TestMain` process per testing framework. This can be addressed in a future PR.
- There is a runtime bug that is triggered by the `(String, Throwable)` constructor of `org.junit.AssumptionViolatedException`. The bug is only present in JUnit self-tests. At runtime, the native test runner exits unexpectedly when the AssumptionViolation is tested. This is why the aforementioned constructor is not available at the moment. Some details:
- The constructor is always made reachable, no matter if it is used or not. This suggests maybe some bug in the reachability analysis and/or code generation.
- After some digging around, I found out that the one to blame is the `Throwable` argument. When the argument is changed to anything else (or removed entirely), then everything works as expected. That is, the constructor is only made reachable when used and the runtime error goes away.
### Testing
- The `test-all` command alias now also runs the JUnit self-tests.
- There is an example JUnit test added in `unit-tests/src/test/scala/junit/JUnitExampleTest.scala`.
### Usage
To enable JUnit support for a Scala Native project, add the following lines to your `build.sbt` file:
```scala
libraryDependencies += "org.scala-native" %%% "junit-runtime" % "0.4.0-SNAPSHOT"
addCompilerPlugin("org.scala-native" % "junit-plugin" % "0.4.0-SNAPSHOT" cross CrossVersion.full)
```
If you want to get more detailed output from the JUnit runtime, also include the following line:
```scala
testOptions += Tests.Argument(TestFrameworks.JUnit, "-a", "-s", "-v")
```
You may then use `test` or `testOnly` in the sbt shell to run all or specific tests, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JUnit support for Scala Native and its projects. See
docs/user/testing.rstfor usage instructions.The feature was mostly ported from Scala.js, with some adaptations for Scala Native.
Notes
TestMain) does not support multiple testing frameworks. For that reason, we now spawn oneTestMainprocess per testing framework. This can be addressed in a future PR.(String, Throwable)constructor oforg.junit.AssumptionViolatedException. The bug is only present in JUnit self-tests. At runtime, the native test runner exits unexpectedly when the AssumptionViolation is tested. This is why the aforementioned constructor is not available at the moment. Some details:Throwableargument. When the argument is changed to anything else (or removed entirely), then everything works as expected. That is, the constructor is only made reachable when used and the runtime error goes away.Testing
test-allcommand alias now also runs the JUnit self-tests.unit-tests/src/test/scala/junit/JUnitExampleTest.scala.Usage
To enable JUnit support for a Scala Native project, add the following lines to your
build.sbtfile:If you want to get more detailed output from the JUnit runtime, also include the following line:
You may then use
testortestOnlyin the sbt shell to run all or specific tests, respectively.