Work around limitation for JDK12+ about j.l.constant.Constable #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catap
force-pushed
the
jdk12
branch
3 times, most recently
from
2a1110e
to
08433f5
Compare
|
If we're going that route, we should also add However, I'm not a fan of adding those, because we will have to leave their methods undeclared, given that we cannot implement them. We're only pushing problems a bit further. Can we fix the test suite so that those types are not inferred instead? |
|
@sjrd yes, you raised a very good point. Let split it to two separated topic:
|
catap
changed the title
catap
changed the title
sjrd
approved these changes
Oct 13, 2020
|
I could just add these changes to the JUnit PR so I don't have to rebase these. |
|
Gosh, I was trying the latest with AdoptOpenJDK 15 and got this. |
|
@errikos yes, scala doesn't compatible with JDK15+. You can use this branch that fixes the issue: scala/scala#9239 |
|
@sjrd let me rebase this branch |
|
@catap Thanks for being patient with your change. Not sure that the second file got rebased correctly. |
`java.lang.Constable` was introduced at JDK12 and simple case: ``` Seq(Double.box(1d), "") ``` has type such as `Seq[java.lang.constant.Constable with ...]` Because Scala-Native hasn't got `java.lang.constant.Constable` and it is impossibly to implement it forces build of test to fail. This way is allow to fix build by forces compiler to use `Object`.
|
@sjrd maybe move forward on it? |
sjrd
changed the title
sjrd
changed the title
vicopem
pushed a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…-native#1941) `java.lang.constant.Constable` was introduced at JDK12 and is a super trait of core boxed classes. This causes code like val seq = Seq(Double.box(1d), "") val elem = seq.head to infer types that mention `Constable`: `seq` is of type `Seq[Constable with ...]` and `elem` of type `Constable with ...`. The latter erases to `Constable`, which results in linking errors. It is unfortunately impossible to correctly implement `Constable` in Scala Native, because it requires reflection, so the general issue is not fixable. This commit works around the issue in our own test suite, by ascribing some values with explicit types, so that `Constable` does not appear in erased types.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
scala-native#1941)" This reverts commit 51576dc.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
scala-native#1941)" This reverts commit 51576dc.
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
…-native#1941) `java.lang.constant.Constable` was introduced at JDK12 and is a super trait of core boxed classes. This causes code like val seq = Seq(Double.box(1d), "") val elem = seq.head to infer types that mention `Constable`: `seq` is of type `Seq[Constable with ...]` and `elem` of type `Constable with ...`. The latter erases to `Constable`, which results in linking errors. It is unfortunately impossible to correctly implement `Constable` in Scala Native, because it requires reflection, so the general issue is not fixable. This commit works around the issue in our own test suite, by ascribing some values with explicit types, so that `Constable` does not appear in erased types.
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…-native#1941) `java.lang.constant.Constable` was introduced at JDK12 and is a super trait of core boxed classes. This causes code like val seq = Seq(Double.box(1d), "") val elem = seq.head to infer types that mention `Constable`: `seq` is of type `Seq[Constable with ...]` and `elem` of type `Constable with ...`. The latter erases to `Constable`, which results in linking errors. It is unfortunately impossible to correctly implement `Constable` in Scala Native, because it requires reflection, so the general issue is not fixable. This commit works around the issue in our own test suite, by ascribing some values with explicit types, so that `Constable` does not appear in erased types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
java.lang.Constable was introduced at JDK12 and it requires to link an application by scala-native via JDK12+.
It oversteps #1938