Fix #1950 Enable handling value classes when generating lambda #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
approved these changes
Nov 30, 2020
WojciechMazur
force-pushed
the
fix/1950_value_class_in_lambda
branch
from
8041ebc
to
ae89630
Compare
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
…ambda (scala-native#1952) * Added test case for issue * Handle value class when generating lambda function
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…ambda (scala-native#1952) * Added test case for issue * Handle value class when generating lambda function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #1950
This PR fixes the mentioned bug - during 2.12 development and porting logic from scala.js logic for handling value class was not fully implemented.