Fix #1943: Support JUnit's @Ignore on test class #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ecda0d9
|
Thanks for this fix and looking into #1943 |
sjrd
requested changes
Oct 22, 2020
junit-runtime/src/main/scala/scala/scalanative/junit/Bootstrapper.scala
Outdated
Show resolved
Hide resolved
junit-test/shared/src/test/scala/scala/scalanative/junit/IgnoreAllTest.scala
Show resolved
Hide resolved
Don't loop over tests when TestClass is ignored
sjrd
reviewed
Oct 22, 2020
junit-runtime/src/main/scala/scala/scalanative/junit/Bootstrapper.scala
Outdated
Show resolved
Hide resolved
junit-runtime/src/main/scala/scala/scalanative/junit/Bootstrapper.scala
Outdated
Show resolved
Hide resolved
sjrd
reviewed
Oct 22, 2020
WojciechMazur
force-pushed
the
fix/1943-JUnit_ignore_should_work_on_test_class
branch
from
1f42e97
to
6427ee3
Compare
sjrd
approved these changes
Oct 22, 2020
sjrd
changed the title
vicopem
pushed a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…cala-native#1961)" This reverts commit cf1b887.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
…cala-native#1961)" This reverts commit cf1b887.
WojciechMazur
deleted the
fix/1943-JUnit_ignore_should_work_on_test_class
branch
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #1943
This PR fixes behaviour of Native JUnit by allowing to annotate whole test class with
Ignore. In such a scenario all tests within that class should be ignored.Proposal to include ignore reason was discarded - it's technically possible, but it violates Native/JVM JUnit outputs compatibility. In JVM version ignore reason is never included in the output