Fix #1999: Clear errno before readdir in posixlib dirent.c #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Posix standard recommends setting errno before calling readdir. This fix will help distinguish the current intermittent errors in DirectoryStreamTest: are they stale errno or are they describing a real condition? This is a surgical change. I will create an Issue for other issues discovered whilst creating this PR.
|
The build of this PR fails for reasons not directly related to the changes of this PR. A set of flaws in ProcessTest are fixed in pending PR #2003. That PR does not |
sjrd
approved these changes
Nov 16, 2020
vicopem
pushed a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
scala-native#2000) The Posix standard recommends setting errno before calling readdir. This fix will help distinguish the current intermittent errors in DirectoryStreamTest: are they stale errno or are they describing a real condition?
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
… dirent.c (scala-native#2000)" This reverts commit 0b4436c.
vicopem
added a commit
to vicopem/scala-native
that referenced
this pull request
Nov 19, 2020
… dirent.c (scala-native#2000)" This reverts commit 0b4436c.
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
scala-native#2000) The Posix standard recommends setting errno before calling readdir. This fix will help distinguish the current intermittent errors in DirectoryStreamTest: are they stale errno or are they describing a real condition?
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
scala-native#2000) The Posix standard recommends setting errno before calling readdir. This fix will help distinguish the current intermittent errors in DirectoryStreamTest: are they stale errno or are they describing a real condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Posix standard recommends setting errno before calling readdir.
This fix will help distinguish the current intermittent errors in
DirectoryStreamTest: are they stale errno or are they
describing a real condition?
This is a targeted surgical change. I will create an Issue for other issues
discovered whilst creating this PR.