New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2012: Fix not reachable definitions of default methods #2040
Fix #2012: Fix not reachable definitions of default methods #2040
Conversation
I've probably run of iteration on a version other than 2.11.x which led me to the wrong conclusions. The bug still exists. |
There is a single error still existing, but it disappears when
The iterator in this test does not override the I propose to merge this PR, followed by merging #2004 when it's ready. |
Wojciech, LGTM! Thank you for doing this work. It is a lot smaller, tighter, and elegant than the NirGenStat.scala work that I about I tested (test-all, which includes scripted) with my zoo of files having JavaDefaultMethods (Map.scala, If it is agreeable to you, I will wait for this PR to be merged, and then rebase PR 2004 and, upon passing, Once that PR builds, I will start rolling though the rest of my JavaDefaultMethod related PRs in the queue, Sound like a plan? Please advise if there is a better way to dance. |
@LeeTibbert let's do this in a way you described |
This PR builds upon merged PRs scala-native#1937 & scala-native#2040 by annotating the existing j.u.f.BiFunction.scala and porting its corresponding BiFunctionTest from Scala.js. The existing file was edited rather than porting the most current Scala.js commit because the latter uses lambdas and those do not play well when using Scala Native with Scala 2.11.
…ds (scala-native#2040) Previously, default method implementations were not used in the reachability check process.
…ds (scala-native#2040) Previously, default method implementations were not used in the reachability check process.
This PR resolves #2012. Default method implementations were up until now not used in the reachability check process.
This issue was also observed #2022, #2023