Support java.util.Date methods using java.time.Instant.
#2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
feature/ju.Date_instant_methods
branch
from
de44b7e
to
2f4e355
Compare
|
You have a typo in the title - should be |
WojciechMazur
changed the title
java.util.Data Instant dependent methodsjava.util.Date Instant dependent methods
sjrd
requested changes
Jan 4, 2021
There was a problem hiding this comment.
This should be accompanied by a port of InstantTest in the unit-test-ext. This is important to make sure that relying on the ArithmeticException is indeed correct.
Otherwise, LGTM. (Probably shouldn't be Draft anymore.)
|
|
WojciechMazur
force-pushed
the
feature/ju.Date_instant_methods
branch
from
7c777f5
to
de3d2a4
Compare
sjrd
approved these changes
Jan 7, 2021
sjrd
changed the title
java.util.Date Instant dependent methodsjava.util.Date methods using java.time.Instant.
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds methods added in Java8 to
java.util.Datethat is methodtoInstantandDate.from(_: Instant)It should be rebased on top of merged #2079 as it contains bootstrap of
testsExtproject and on top of #2087 whereInstant.ofEpochSecondsmethod used in tests was implemented.