Fix #2313: Defect in j.n.InetAddress#createIPStringFromByteArray #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if values in the last group were all equal to 0, they would be ignored in the string.
jchyb
changed the title
WojciechMazur
approved these changes
Aug 11, 2021
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…teArray (scala-native#2348) * Fix createIPStringFromByteArray ignoring last group Previously, if values in the last group were all equal to 0, they would be ignored in the string. * Add test for issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, createIPStringFromByteArray would ignore last group if it was equal to 0. A simple test for the issue was added as well. Since JVM uses lowercase characters in String addresses, explicit String comparison would not work here.