Add UnsafeRichArray#at syntax extension
#2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Oct 7, 2022
Comment on lines
+127
to
+130
| /** Scala Native unsafe extensions to Arrays */ | ||
| implicit class UnsafeRichArray[T](val value: Array[T]) extends AnyVal { | ||
| @inline def at(i: Int): Ptr[T] = value.asInstanceOf[runtime.Array[T]].at(i) | ||
| } |
There was a problem hiding this comment.
This is the new syntax, all other modifications are applying it.
LeeTibbert
approved these changes
Oct 7, 2022
|
I suspect that my pending PR #2877 has quite a few places which will This PR makes it much easier to get the idiom right. Should make maintenance |
|
Do you think the "at" method name is specific enough? |
WojciechMazur
approved these changes
Oct 10, 2022
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 27, 2022
* Add `UnsafeRichArray#at` syntax extension * Use it more
WojciechMazur
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Add `UnsafeRichArray#at` syntax extension * Use it more
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
Oct 27, 2022
* Add `UnsafeRichArray#at` syntax extension * Use it more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes an unsafe syntax extension for retrieving the
Ptrbacking an array, making official the widely-used trick of casting to aruntime.Arrayand accessing it like that.The new syntax is then adopted within the codebase.