Init Git submodules after syncing with upstream repo #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git submodules are now initialized after the latest changes from the upstream repo are merged into Scala Steward's fork instead of directly after cloning our fork and before changes are synced. I hope that this is enough to ensure that our submodules are always in sync with the submodules of the upstream repos. If we're lucky, this closes #339.
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
+ Coverage 74.68% 74.80% +0.12%
==========================================
Files 123 123
Lines 2074 2076 +2
Branches 53 57 +4
==========================================
+ Hits 1549 1553 +4
+ Misses 525 523 -2
Continue to review full report at Codecov.
|
|
This seems to be working. Here are two PRs in a repo that has a submodule: The first one was created before this PR was merged and contains changes to the submodule. The second PR was created after this PR has been merged and contains no changes to the submodule. \o/ |
|
@fthomas This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git submodules are now initialized after the latest changes from the
upstream repo are merged into Scala Steward's fork instead of directly
after cloning our fork and before changes are synced. I hope that this
is enough to ensure that our submodules are always in sync with the
submodules of the upstream repos.
If we're lucky, this closes #339.