New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13 Stream.append (deprecated) has changed semantics #11392

Open
jrudolph opened this Issue Feb 5, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@jrudolph
Copy link
Member

jrudolph commented Feb 5, 2019

Before the Stream.append's parameter was by-name, now it's not any more leading to issues.

https://github.com/scala/scala/blob/8a52aa19703004f0eb22d72a1efc82617924db32/src/library/scala/collection/immutable/Stream.scala#L74-L75

If it's deprecated anyway, it would make sense to keep the semantics close to what it was before. That will also help with cross-compiling.

@julienrf

This comment has been minimized.

Copy link

julienrf commented Feb 5, 2019

Indeed, I don’t know why we changed this. It’s probably an oversight. We should just make it take a by-name parameter instead (it delegates to lazyAppendedAll, which does take a by-name parameter).

@SethTisue SethTisue added this to the 2.13.0-RC1 milestone Feb 5, 2019

@WellingR

This comment has been minimized.

Copy link

WellingR commented Feb 12, 2019

I am having a look at this, as it seems fairly easy to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment