Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in TableStepperBase on trySplit #11468

Closed
lrytz opened this Issue Apr 3, 2019 · 11 comments

Comments

Projects
None yet
3 participants
@lrytz
Copy link
Member

commented Apr 3, 2019

@lrytz

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@lrytz

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

(found while porting tests over from java8-compat, https://github.com/scala/scala/compare/2.13.x...lrytz:java8-tests?expand=1)

@SethTisue SethTisue added this to the 2.13.0 milestone Apr 3, 2019

@SethTisue

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@lrytz is 2.13.0 a reasonable milestone for this?

@Ichoran

This comment has been minimized.

Copy link

commented Apr 4, 2019

I'll test the trySplits tonight. I think fixing them all will be practical in a short period of time.

@Ichoran

This comment has been minimized.

Copy link

commented Apr 4, 2019

Verified, and I think there are correctness issues with all the other set/map splitters. The others all seem fine. I'll investigate shortly.

@Ichoran

This comment has been minimized.

Copy link

commented Apr 4, 2019

BitSets also keep returning empty steppers instead of eventually giving null on splits. Bad practice, though the Java API tolerated it last I checked.

@lrytz

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

I think we don't need to delay RC1 over these bugs, but should fix them for RC2 / .0

@SethTisue SethTisue modified the milestones: 2.13.0, 2.13.0-RC2 Apr 4, 2019

@Ichoran

This comment has been minimized.

Copy link

commented Apr 4, 2019

Yeah, okay. I've fixed this one; will submit one PR to fix both the TableStepper bug and the ChampStepper one (it skips elements).

@Ichoran

This comment has been minimized.

Copy link

commented Apr 7, 2019

Have a fix in https://github.com/Ichoran/scala/tree/issue-11468

Is 2.13.x still what I should rebase against?

@SethTisue

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

yes

@lrytz

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

@Ichoran I included your commit in my PR with the new tests: scala/scala#7970. It fixes the issues I observed. If you have time to review this one, that would be great :)

@SethTisue SethTisue changed the title Infinite loop inm TableStepperBase on trySplit Infinite loop in TableStepperBase on trySplit Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.