Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery vulnerability in scala-lang.org #11594

Open
exoego opened this issue Jun 26, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@exoego
Copy link

commented Jun 26, 2019

White working on #11567 (vulnerability in ScalaDoc), I found HTML templates for scala-lang.org also uses jQuery.js 2.1.3 that is considered vulnerable.

Use-site
https://github.com/scala/scala/blob/a37e40399b65554241ee0f4276a915b3d0f723f9/spec/_layouts/toc.yml#L9

I suggest to migrate to jQuery 3 (as planed so in #11567).

@SethTisue SethTisue modified the milestones: 2.13.1, 2.12.9 Jul 4, 2019

@SethTisue SethTisue added the security label Jul 4, 2019

@eed3si9n eed3si9n self-assigned this Jul 19, 2019

eed3si9n added a commit to eed3si9n/scala that referenced this issue Jul 19, 2019

Update jQuery used in specs page to 3.4.1
Fixes scala/bug#11594

I used jQuery Migrate (https://github.com/jquery/jquery-migrate/) to let it print out deprecation warnings, and updated `.bind` to `.on`.

eed3si9n added a commit to eed3si9n/scala that referenced this issue Jul 19, 2019

Update jQuery used in specs page to 3.4.1
Fixes scala/bug#11594

I used jQuery Migrate (https://github.com/jquery/jquery-migrate/) to let it print out deprecation warnings, and updated `.bind` to `.on`.

Here's how I locally tested the page:

```
bundle exec jekyll build -s spec/ -d build/spec
ruby -run -e httpd build/spec -p 9090
```
@eed3si9n

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Here's my PR - scala/scala#8250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.