Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE typechecking invalid code when continuations are enabled #3628

Closed
scabug opened this issue Jun 30, 2010 · 4 comments
Closed

NPE typechecking invalid code when continuations are enabled #3628

scabug opened this issue Jun 30, 2010 · 4 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Jun 30, 2010

[Elided very sloppy report, replacing with substance.]

import scala.actors.Actor._

object Test {
  val impl: Actor = actor {
    loop {
      react { 
        case 1 => impl ! 2
      }
    }
  }
}

Notice scala.actors.Actor is not imported. scalac crashes during compilation, but only if continuations are enabled.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jun 30, 2010

Imported From: https://issues.scala-lang.org/browse/SI-3628?orig=1
Reporter: Ittay Dror (ittayd)
Attachments:

  • t3628.diff (created on Jul 29, 2011 8:32:56 PM UTC, 1548 bytes)
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 12, 2010

@phaller said:
(In r22539) Added test case for see #3628 in pending.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 29, 2011

Topher (topher.the.geek) said:
This has already been fixed. I have attached a patch that moves phaller's test from pending into files/continuations-neg and corrects the expected output. It's not a very deep patch, but it does allow this bug to be closed.

Being that this moves files, you'll want to apply it with:

patch -p0 -E -i t3628.diff
svn rm test/pending/continuations-neg/t3628.check test/pending/continuations-neg/t3628.scala
svn add test/files/continuations-neg/t3628.check test/files/continuations-neg/t3628.scala
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 29, 2011

Commit Message Bot (anonymous) said:
(extempore in r25418) Moved test out of pending, closes #3628, no review.

@scabug scabug closed this Jul 29, 2011
@scabug scabug added this to the 2.10.0 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.