Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods which are scheduled for removal for 2.10 #4860

Closed
scabug opened this issue Jul 31, 2011 · 3 comments
Closed

Remove deprecated methods which are scheduled for removal for 2.10 #4860

scabug opened this issue Jul 31, 2011 · 3 comments
Assignees

Comments

@scabug
Copy link

@scabug scabug commented Jul 31, 2011

Remove the methods marked with @deprecated with since argument < 2.9 for the 2.10 release.

Because of the huge amount of removals this time it would make sense to do it early, so that people can start complaining early, too.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 31, 2011

Imported From: https://issues.scala-lang.org/browse/SI-4860?orig=1
Reporter: @soc
Attachments:

  • tests (created on Jul 31, 2011 7:54:53 PM UTC, 172064 bytes)
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 31, 2011

@soc said (edited on Jul 31, 2011 6:42:23 PM UTC):
Pull request: scala/scala#64

Notable things:

  • The top-level offenders scala.Cell, scala.CountedIterator and scala.NotDefinedError are finally gone.
  • Cleanup in the scala package object (Tuples), Product and Function.
  • The collection library is considerably cleaner.
  • scala.Math is gone, scala.MathCommon is consolidated into the scala.math package object.
  • Failing tests were adapted, all tests pass.

The case of methods of one class overriding deprecated methods of another class without @deprecated appeared three times:

1.: findIndexOf
Deprecated in SeqLike [0], overridden in SeqProxyLike [1], SeqForwarder [2] without @deprecated.
=> Removed

2.: +
Deprecated in BufferLike [3], overridden in SynchronizedBuffer [4] without @depecated.
=> Removed

3.: size_=
UIElement's size_= [5] is deprecated, but overridden in Window [6].
I'm not sure what's intended:

  • remove the method from Window, too
  • remove just the override modifier
    => Kept (after asking on #scala)

[0] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqLike.scala#L124

[1] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqProxyLike.scala#L36

[2] https://github.com/scala/scala/blob/master/src/library/scala/collection/generic/SeqForwarder.scala#L38

[3] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/BufferLike.scala#L243

[4] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/SynchronizedBuffer.scala#L48

[5] https://github.com/scala/scala/blob/master/src/swing/scala/swing/UIElement.scala#L101

[6] https://github.com/scala/scala/blob/master/src/swing/scala/swing/Window.scala#L56

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Aug 15, 2011

Commit Message Bot (anonymous) said:
(extempore in r25511) Removing the code which has been deprecated since 2.8.0. Contributed by
Simon Ochsenreither, although deleting code is such fun one hesitates to
call it a contribution. Still, we will. Closes #4860, no review.

@scabug scabug closed this Aug 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.