Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migration messages, make the compiler print the migration version by default, adjust usage of @migration to correspond to @deprecated and make -Xmigration configurable with a threshold #4990

Closed
scabug opened this issue Sep 12, 2011 · 6 comments

Comments

@scabug
Copy link

@scabug scabug commented Sep 12, 2011

The title actually tells everyting.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Sep 12, 2011

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Sep 12, 2011

@soc said:
Actually I already did that a few weeks ago: https://github.com/oberon-team/scala/commits/migration-update

=====================
Reworked migration:

  • The @migration can now be used like @Deprecation, old syntax is still supported, but deprecated.
  • Xmigration accepts a version string like "2.8" now. This will show only migration warnings since that version. Default is "2.9".
  • Improved the wording and the consistency of most migration messages, migration warnings now also show the version the change occurred.
    =====================

I only have one problem with that solution left:

Paul suggested that I change -Xmigration from BooleanSetting to ChoiceSetting, but although I can set a default value scala/scalac don't accept "-Xmigration" without a value anymore. I would have expected that "-Xmigration" would be accepted and the default value to be chosen if no argument to -Xmigration was given.

Maybe someone can give me a hint on how to make -Xmigration behave that way ...

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Sep 17, 2011

@soc said:
I fixed the remaining problems, pull request with additional tests is here:

scala/scala#91

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Oct 26, 2011

@soc said:
This is now almost 6 weeks old.
Could someone please at least reply if it needs further changes?

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Oct 31, 2011

@paulp said:
"Someone", are you expecting to find someone other than me? I don't know if it needs further changes, I don't have time to look at it yet.

@SethTisue

This comment has been minimized.

Copy link
Member

@SethTisue SethTisue commented Mar 2, 2018

we're not using -Xmigration these days

@SethTisue SethTisue closed this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.