Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually created toolbox does not respect passed in settings #5239

Closed
scabug opened this issue Nov 28, 2011 · 2 comments
Closed

Manually created toolbox does not respect passed in settings #5239

scabug opened this issue Nov 28, 2011 · 2 comments
Assignees

Comments

@scabug
Copy link

@scabug scabug commented Nov 28, 2011

Given this code, the type checker won't print the typings, even though we explicitly ask it to do so:

val settings = new Settings
settings.Ytyperdebug.value = true

val reporter = new ConsoleReporter(settings)
val toolbox = new ToolBox(reporter)
val ttree = toolbox.typeCheck(code.tree)
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Nov 28, 2011

Imported From: https://issues.scala-lang.org/browse/SI-5239?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Nov 28, 2011

Commit Message Bot (anonymous) said:
(burmako in r26081) Reflection toolboxes now respect settings that are provided to them.

Before the fix CompilerCommand lacked the (args, settings, errorFn) ctor.
I added it and provided means to augment passed settings with custom errorFn.

Closes #5239. Review by odersky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.