Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override error message is misleading and misses an obvious alternative solution. #5358

Closed
scabug opened this issue Jan 5, 2012 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Jan 5, 2012

Consider this code:

trait A { def hi = "A" }
trait B { def hi = "B" }
class C extends A with B

It results in the following compiler error message:

<console>:9: error: overriding method hi in trait A of type => String;
 method hi in trait B of type => String needs `override' modifier
       class C extends A with B
             ^

The problem is that

  • the solution suggested does not work in most cases, because A and B need to be in some inheritance relationship for it to work:
scala> trait B { override def hi = "B" }
<console>:7: error: method hi overrides nothing
       trait B { override def hi = "B" }
                              ^
  • the possibility to use override in C is not mentioned at all:
class C extends A with B {
  override def hi = "C"
}

Maybe it is possible to improve this message.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jan 5, 2012

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Feb 20, 2012

@paulp said:
a6a9684f5b

@scabug scabug closed this Feb 20, 2012
@scabug scabug added the enhancement label Apr 7, 2017
@scabug scabug added this to the 2.10.0 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.