Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve names of pattern variables in bytecode #5739

Closed
scabug opened this issue May 3, 2012 · 9 comments
Closed

preserve names of pattern variables in bytecode #5739

scabug opened this issue May 3, 2012 · 9 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented May 3, 2012

(No description for SI-5739.)

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented May 3, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5739?orig=1
Reporter: @xeno-by
See #5158, #6070
Attachments:

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jun 24, 2012

@xeno-by said:
Why was the priority lowered from critical? This issue pretty much forces one to use old patmat when debugging patmat-heavy code.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jun 24, 2012

@adriaanm said:
because I have 131 bugs assigned to me, give or take,
and I need to prioritize which ones I'll fix first
major is still pretty high on my list

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 3, 2012

@adriaanm said:
to further improve debuggability, we should also emit local variables for case class fields (this would then fix #5158)

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 20, 2012

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jul 28, 2012

@adriaanm said:
reopening because it causes performance regressions

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Aug 7, 2012

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jan 29, 2013

@adriaanm said:
reopening for a further tweak: shouldn't emit a local variable for debuggability if the original name was a wildcard -- it seems unlikely to matter and impacts bytecode size unnecessarily

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jan 31, 2013

@adriaanm said (edited on Feb 3, 2013 5:49:53 PM UTC):
refined in scala/scala#2033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.