Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashTable.initialSize isn't used at all #5804

Closed
scabug opened this issue May 18, 2012 · 12 comments

Comments

@scabug
Copy link

commented May 18, 2012

initialSize in the HashTable trait isn't used at all. Instead, the initialSize function of the companion object is used. This makes it pointless to override this function and provide a reasonable initialSize for loading a known number of entries. This results in very bad performance when loading a hash table with many thousand entries because the array gets continuously resized until it finally fits the number of entries.

@scabug

This comment has been minimized.

Copy link
Author

commented May 18, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5804?orig=1
Reporter: Christian Schlichtherle (christian_schlichtherle)
Affected Versions: 2.8.0, 2.9.2

@scabug

This comment has been minimized.

Copy link
Author

commented May 22, 2012

Christian Schlichtherle (christian_schlichtherle) said:
Thanks for the quick fix. Which versions will it appear in?

@scabug

This comment has been minimized.

Copy link
Author

commented May 22, 2012

@axel22 said:
This should be in 2.10.

@scabug

This comment has been minimized.

Copy link
Author

commented May 22, 2012

Christian Schlichtherle (christian_schlichtherle) said (edited on May 22, 2012 11:03:11 AM UTC):
Any chances to port it back to 2.8.X and 2.9.X? I'm asking because I'm working on a library (truevfs.java.net) which would ideally work well with any latest version since 2.8+ (you might want to edit "Fix Version/s").

@scabug

This comment has been minimized.

Copy link
Author

commented May 22, 2012

@axel22 said:
We cannot commit to these kind of backports, but we do accept pull requests for any backports.

@scabug

This comment has been minimized.

Copy link
Author

commented May 24, 2012

Christian Schlichtherle (christian_schlichtherle) said:
Sorry, I don't get this. Are you expecting me to do something about this?

@scabug

This comment has been minimized.

Copy link
Author

commented May 24, 2012

@axel22 said:
Due to a limited amount of time, the EPFL policy is not to do backports to earlier Scala releases. These kinds of backports are part of a commercial support offered by certain companies.
But pull requests with backports against earlier branches in the main scala repo at github are welcome.
I am not expecting you to do this, of course, but if you need it badly - you certainly can.

@scabug

This comment has been minimized.

Copy link
Author

commented Jan 4, 2013

Christian Schlichtherle (christian_schlichtherle) said:
Any chance this will get ported back to 2.9.3? I mean a bug is a bug is a bug, isn't it?

@scabug

This comment has been minimized.

Copy link
Author

commented Jan 23, 2013

@adriaanm said (edited on Jan 23, 2013 12:06:52 AM UTC):
fixed for 2.10 in f51dbd5564 -- backport (by Typesafe) to 2.9.3-rc2 pending subject to available time

@scabug

This comment has been minimized.

Copy link
Author

commented Jan 23, 2013

@adriaanm said:
reopened for potential backport

@scabug

This comment has been minimized.

Copy link
Author

commented Jan 31, 2013

@adriaanm said:
also pushing to 2.9.4-RC1

@scabug

This comment has been minimized.

Copy link
Author

commented Nov 21, 2013

@retronym said:
The backport isn't forthcoming, closing this ticket.

@scabug scabug closed this Nov 21, 2013

@scabug scabug added the backport label Apr 7, 2017

@scabug scabug added this to the 2.10.0-M3 milestone Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.