Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partest does not work if directory's path contains a space #622

Closed
scabug opened this issue Mar 9, 2008 · 5 comments
Closed

Partest does not work if directory's path contains a space #622

scabug opened this issue Mar 9, 2008 · 5 comments
Assignees
Labels

Comments

@scabug
Copy link

@scabug scabug commented Mar 9, 2008

"run", "jvm", "jvm5" and "res" tests fail with Partest (and SuperSABBUS) if Scala directory's path contains spaces.

To test, SVN checkout Scala trunk into "scala dir" and run "ant -f sabbus suite.test".

  [partest] Compiling and running files
  [partest] testing: [...]/files/jvm/xmlmore.scala                                [FAILED]
  [partest] Exception in thread "main" java.lang.NoClassDefFoundError: dir/test/files/jvm/xmlmore-run/obj:/localhome/dubochet/scala
...
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Mar 9, 2008

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jan 14, 2009

@odersky said:
Milestone next_bugfix deleted

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Nov 13, 2011

Commit Message Bot (anonymous) said:
(extempore in r25994) Working on the runners.

Removed assumption that bash is in /bin. Removed --posix option to bash.
Modernized shell constructs: $() instead of ``, [[ ]] instead of [ ].
Added -debug option for all runners which will show you the exact java
command line being run before running it. Added -usebootcp to complement
-nobootcp, and made regular classpath the default on cygwin. Quoted more
things to give us a fighting chance against spaces and parens in paths.

I took the waste-half-a-day step of installing vmware fusion so I could
install windows so I could install cygwin so I could install scala under
cygwin so I could see if it still worked. Seems to. We still desperately
need some way of testing not only everything I'm attempting to address
in this pile of patches but everything which is most likely now regressing.

:javap now sort of works on windows (not for repl-defined classes as yet)
if JAVA_HOME is set such that I can find tools.jar. Closes #4959.
(Risks breaking and) references #2092. References #622 since that
shouldn't be hard to get working.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Nov 21, 2011

Commit Message Bot (anonymous) said:
(szeiger in r26040) Always build command lines in partest as Seq[String] instead of space-separated command.

Closes #1510 which is actually caused by a bad command line string when the path to Java contains a space, and not by long path names per se. References #622 since this commit fixes the specific error described there (not closing because follow-up bugs remain).

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Nov 22, 2011

Commit Message Bot (anonymous) said:
(szeiger in r26047) Make partest work with spaces in the path (from batch script and ant task).

  • The 'partest' ant task gets a new 'compilerargs' element for scalac options (like in scalacfork and javac).
  • Fixed argument list handling in partest task.
  • Further improvements to argument list handling for all ant tasks.
  • Fixed argument list handling in DirectTest (used by partest shell scripts)
  • Fixed path handling in several test cases.

Closes #622. Review by phaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.