Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols aren't always unique for equal strings #6706

Closed
scabug opened this issue Nov 24, 2012 · 3 comments
Closed

Symbols aren't always unique for equal strings #6706

scabug opened this issue Nov 24, 2012 · 3 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Nov 24, 2012

See the following REPL session:

Welcome to Scala version 2.10.0-RC3 (OpenJDK 64-Bit Server VM, Java 1.7.0_09).
Type in expressions to have them evaluated.
Type :help for more information.

scala> var name = "foo" + 1
name: String = foo1

scala> var s1 = Symbol(name)
s1: Symbol = 'foo1

scala> s1 = null
s1: Symbol = null

scala> System.gc

scala> val s2 = Symbol("foo1")
s2: Symbol = 'foo1

scala> name = null
name: String = null

scala> System.gc

scala> val s3 = Symbol("foo1")
s3: Symbol = 'foo1

scala> s2 eq s3
res2: Boolean = false

The problem arises if the symbol object for a particular name is garbage collected (so the weak reference stored in Symbol's weak hash map is null), but the string for that name has not been garbage collected (so the key still exists in the weak hash map). If a new symbol object with the same name is added, the weak hash map key will be a different object from the name field of the symbol object. If that string is subsequently garbage collected, the weak hash map entry disappears, so if the symbol is then created for a third time, it will end up being a different object from the second one.

For additional background, see https://groups.google.com/d/topic/scala-user/mp_pSbfRECI/discussion

@scabug
Copy link
Author

@scabug scabug commented Nov 24, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6706?orig=1
Reporter: @paulbutcher
Affected Versions: 2.9.2, 2.10.0-RC2

Loading

@scabug
Copy link
Author

@scabug scabug commented Nov 24, 2012

Loading

@scabug
Copy link
Author

@scabug scabug commented Nov 26, 2012

@paulp said:
d0de367e72

Loading

@scabug scabug closed this Nov 26, 2012
@scabug scabug added this to the 2.10.1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants