Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upseek clarification about necessary and sufficient conditions for inclusion in InnerClasses JVM attribute #6759
Comments
This comment has been minimized.
This comment has been minimized.
|
Imported From: https://issues.scala-lang.org/browse/SI-6759?orig=1 |
This comment has been minimized.
This comment has been minimized.
|
@gkossakowski said: |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The JVM spec states in Sec. 4.7.6 that for each
CONSTANT_Class_info(constant-pool entry) which represents a class or interface that is not a member of a package an entry should be made in the class' InnerClasses JVM attribute.According to the above, the mere fact an inner class is mentioned in, for example, an annotation wouldn't be reason enough for adding it to the InnerClasses JVM attribute.
However that's what GenASM (apparently?) does.
As an aside, this issue came up in the context of GenBCode, where
refreshInnerClasses()in file BCodeOpt.scala follows a literal interpretation of the spec.