Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn implementation restriction for SI-5954 from 2.10.x into a warning #7070

Closed
scabug opened this issue Feb 4, 2013 · 3 comments
Closed

Turn implementation restriction for SI-5954 from 2.10.x into a warning #7070

scabug opened this issue Feb 4, 2013 · 3 comments
Labels
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Feb 4, 2013

The implementation restriction created from #5954 has two problems. 1) The problematic code works fine if compile with sbt. That means the restriction is breaking some people needlessly. 2) It's not binary compatible. The implementation restriction needs to be turned into a warning and the setting to get around the restriction needs to be removed.

@scabug
Copy link
Author

@scabug scabug commented Feb 4, 2013

@scabug
Copy link
Author

@scabug scabug commented Feb 6, 2013

@scabug
Copy link
Author

@scabug scabug commented Feb 7, 2013

@adriaanm said:
in principle we don't introduce new warnings/errors/different type inference/different implicit resolution in minor releases, but I feel there's a case to be made here of how broken package objects are that we should warn

@scabug scabug closed this Feb 8, 2013
@scabug scabug added the has PR label Apr 7, 2017
@scabug scabug added this to the 2.10.1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant