New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing of annotated trees not idempotent #7163

Closed
scabug opened this Issue Feb 21, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@scabug
Copy link

scabug commented Feb 21, 2013

typedAnnotated transforms an Annotated tree into a Typed tree. The
original field of the result is set to the Annotated tree.

The bug was that typedAnnotated was using the untyped Annotated tree
as original, but also set its type. When re-typing later on the same
Annotated tree, the typer would consider it as alreadyTyped. This
is incorrect, the typer needs to convert Annotated trees to Typed.

Also, the Annotated tree only had its type field set, but its children
were still untyped. This crashed the compiler lateron, non-typed trees
would get out of the typing phase.

@scabug

This comment has been minimized.

Copy link
Author

scabug commented Feb 21, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7163?orig=1
Reporter: @retronym
Affected Versions: 2.10.1-RC1

@scabug

This comment has been minimized.

Copy link
Author

scabug commented Feb 22, 2013

@scabug scabug closed this Feb 25, 2013

@scabug scabug added this to the 2.10.1 milestone Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment