Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place silent type checking, adaptToMemberWithArgs, filter/withFilter => "erroneous or inaccessible type" #7239

Closed
scabug opened this issue Mar 11, 2013 · 3 comments

Comments

@scabug
Copy link

@scabug scabug commented Mar 11, 2013

object Test {
  def BrokenMethod(): HasFilter[(Int, String)] = ???

  trait HasFilter[B] {
    def filter(p: B => Boolean) = ???
  }

  trait HasWithFilter {
    def withFilter = ???
  }

  object addWithFilter {
    trait NoImplicit
    implicit def enrich(v: Any)
                       (implicit F0: NoImplicit): HasWithFilter = ???
  }

  BrokenMethod().withFilter(_ => true) // okay
  BrokenMethod().filter(_ => true)     // okay

  locally {
    import addWithFilter._
    BrokenMethod().withFilter((_: (Int, String)) => true) // okay
  }

  locally {
    import addWithFilter._
    // adaptToMemberWithArgs sets the type of the tree `x`
    // to ErrorType (while in silent mode, so the error is not
    // reported. Later, when the fallback from `withFilter`
    // to `filter` is attempted, the closure is taken to have
    // have the type `<error> => Boolean`, which conforms to
    // `(B => Boolean)`. Only later during pickling does the
    // defensive check for erroneous types in the tree pick up
    // the problem.
    BrokenMethod().withFilter(x => true) // erroneous or inaccessible type.
  }
}

This shares a root cause with #7223.

Contrary to my expectation, this code compiles under Scala 2.9.2.

@scabug
Copy link
Author

@scabug scabug commented Mar 11, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7239?orig=1
Reporter: @retronym
Affected Versions: 2.10.0
See #7176, #6921

@scabug
Copy link
Author

@scabug scabug commented Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants