Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tb.parse returns unpositioned trees #7331

Closed
scabug opened this issue Apr 4, 2013 · 8 comments
Closed

tb.parse returns unpositioned trees #7331

scabug opened this issue Apr 4, 2013 · 8 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Apr 4, 2013

00:22 ~/Projects/210x/sandbox (2.10.x)$ scala
Welcome to Scala version 2.10.2-20130329-164357-00fcd46ed0 (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_43).
Type in expressions to have them evaluated.
Type :help for more information.

scala> val tb = cm.mkToolBox()
tb: scala.tools.reflect.ToolBox[reflect.runtime.universe.type] = scala.tools.reflect.ToolBoxFactory$ToolBoxImpl@5101a031

scala> tb.parse("x").pos
res0: tb.u.Position = NoPosition
@scabug
Copy link
Author

@scabug scabug commented Apr 4, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7331?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0

@scabug
Copy link
Author

@scabug scabug commented Apr 4, 2013

@scabug
Copy link
Author

@scabug scabug commented Aug 1, 2013

@jedesah said:
Hi,

Is there anything I can do to help get this bug fixed?

I have a project (https://github.com/jedesah/scala-codesheet-api if your curious) which has just under 100 tests and almost all of them will fail with unpositioned trees.

Having to use a custom version of Scala is giving me trouble in regard to integrating my evaluation engine into my Play! webapp. For what it's worth in regard to Paul's questions, I patched the compiler by removing the assert in setPos and therefore the guard against emptyValDef because that makes the most sense to me.

While we're at it. Once the patch is applied the lines of the positions are off by one. I believe this is due to the Wrapper Object that is added in order to support compiling standalone expressions. I just handle it in my client code but it would probably be nicer to fix this internally.

Like I said is there anything I can do to help advance this issue. I would be very happy if this could be fixed as part of the next stable release of the 2.10.x branch.

Thx for your time

@scabug
Copy link
Author

@scabug scabug commented Aug 1, 2013

@xeno-by said:
Since you mentioned that you already have a patched version of the compiler, could you submit a pull request to scala/scala? You could also include the fix to the off-by-one problem.

@scabug
Copy link
Author

@scabug scabug commented Aug 5, 2013

@jedesah said:
Here we go: scala/scala#2794

@scabug
Copy link
Author

@scabug scabug commented Aug 5, 2013

@xeno-by said:
Thank you! I will take a look today.

@scabug
Copy link
Author

@scabug scabug commented Aug 16, 2013

@scabug scabug closed this Aug 16, 2013
@scabug
Copy link
Author

@scabug scabug commented Aug 16, 2013

@scabug scabug added this to the 2.11.0-M5 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants