Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala.bat does not double quote %COMSPEC% path #7687

Closed
scabug opened this issue Jul 23, 2013 · 3 comments
Closed

scala.bat does not double quote %COMSPEC% path #7687

scabug opened this issue Jul 23, 2013 · 3 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Jul 23, 2013

scala.bat does not double quote the %COMSPEC% path variable when setting the exit code (last line of the script):

@@%COMSPEC% /C exit %errorlevel% >nul

Instead of:

@@"%COMSPEC%" /C exit %errorlevel% >nul

This is usually ok because cmd.exe is in system32 by default (that path has no space in it), but it can be elsewhere in some configs and it creates a useless error message when the user is closing the REPL, like 'Unknown command "C:\Program"'

Related scala-user discussion: https://groups.google.com/d/topic/scala-user/FBgClRSJ2qc/discussion

@scabug
Copy link
Author

@scabug scabug commented Jul 23, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7687?orig=1
Reporter: @gourlaysama
Affected Versions: 2.10.2, 2.11.0-M4

@scabug
Copy link
Author

@scabug scabug commented Jul 23, 2013

@scabug
Copy link
Author

@scabug scabug commented Aug 16, 2013

@scabug scabug closed this Aug 16, 2013
@scabug scabug added this to the 2.10.3-RC1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants