Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation compiler reports false positive: illegal cyclic reference involving package #8029

Closed
scabug opened this issue Dec 4, 2013 · 4 comments

Comments

@scabug
Copy link

@scabug scabug commented Dec 4, 2013

The following code was extracted from the 3rd assignment on the Coursera Reactive class.

package object nodescala { 
  trait Subscription

  object Subscription {
    def apply() = new Subscription {}
  }
}

If you open the above file in the Scala IDE for Eclipse and type a whitespace, the presentation compiler will report the following error:

illegal cyclic reference involving package nodescala

While no issue is reported by the build compiler.

This is a regression wrt 2.10.3, and I hope we can consider it a blocker for 2.10.4-RC1.

My hope is that it should be relatively easy to create a presentation compiler test that demonstrates the issue. In fact, it should be enough to fully typecheck the source and check if any problem is reported.

@scabug
Copy link
Author

@scabug scabug commented Dec 4, 2013

Imported From: https://issues.scala-lang.org/browse/SI-8029?orig=1
Reporter: @dotta
Affected Versions: 2.10.4-RC1

@scabug
Copy link
Author

@scabug scabug commented Dec 4, 2013

@retronym said:
Marking as a blocker, I'll take a look at this if noone beats me to it.

@scabug
Copy link
Author

@scabug scabug commented Dec 4, 2013

@retronym said:
I could reproduce this in a test case, and have a fix:

retronym/scala@scala:2.10.x...ticket/8029

I'll submit a PR tomorrow after I address the small TODOs in the commit message.

@scabug
Copy link
Author

@scabug scabug commented Dec 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants