Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local in scala.concurrent #9835

Open
scabug opened this issue Jun 28, 2016 · 11 comments
Open

Local in scala.concurrent #9835

scabug opened this issue Jun 28, 2016 · 11 comments

Comments

@scabug
Copy link

@scabug scabug commented Jun 28, 2016

It would be nice to have something equivalent to Twitter's Local in scala.concurrent.

In other words, something like Java's ThreadLocal which follows the application flow (rather than JVM threads) when using scala.concurrent.Future?

@scabug
Copy link
Author

@scabug scabug commented Jun 28, 2016

Imported From: https://issues.scala-lang.org/browse/SI-9835?orig=1
Reporter: Mikael Ståldal (mikaelstaldal)
Affected Versions: 2.11.8

Loading

@scabug scabug added this to the Backlog milestone Apr 7, 2017
@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Feb 6, 2018

Would you accept a PR for this? If so it might be a good first issue.

Loading

@viktorklang
Copy link

@viktorklang viktorklang commented Feb 6, 2018

@eed3si9n I have some concerns, but it would be interesting to see what a solution would look like.

(I have some Future improvements in the works: https://github.com/viktorklang/scala-futures)

Loading

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 6, 2018

the usual gatekeeper on this is @viktorklang. I'll provisionally add the "good first issue" label because unlike many scala/scala repo things this is pretty self-contained, no big ramp-up required. but anyone interested should be advised that they should propose a design and run it by https://contributors.scala-lang.org before writing a bunch of code

Loading

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 6, 2018

I made a "concurrency" label, we strangely didn't have one.

Loading

@viktorklang
Copy link

@viktorklang viktorklang commented Feb 6, 2018

@SethTisue Thanks for creating the label, Seth!

Loading

@mghildiy
Copy link

@mghildiy mghildiy commented Feb 28, 2018

Does it need deep understanding of concurrency in Scala?

Loading

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 1, 2018

I don't know about "deep", but you should probably have some experience working with Future in order to propose a design.

Loading

@jsw
Copy link

@jsw jsw commented Mar 26, 2018

  • What are the design considerations for a good solution?
  • What are the pros/cons of the Twitter implementation, and why did it not ultimately become part of the Scala SDK?
  • Are there any links to previous discussion of this topic?

Loading

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 31, 2018

@jsw you might try starting a thread on it on https://contributors.scala-lang.org to call attention to this?

Loading

@jsw
Copy link

@jsw jsw commented Apr 7, 2018

@SethTisue Thanks for the suggestion. For reference, pasting a link here https://contributors.scala-lang.org/t/locals-in-scala-concurrent/1785

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants