Update Spanish translation of basics.md #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some details are missing (intro and fiddle run), I'll add them asap |
Contributor
|
Thanks for doing this! I can't review it as I am not fluent, but it's definitely something we need more of ❤️ |
Contributor
Author
|
Who can review? I can ask someone who speak Spanish :) |
Member
|
Perhaps @diesalbla, @jvican, and/or @ignasi35 have some spare bandwidth? |
diesalbla
approved these changes
May 5, 2019
Contributor
diesalbla
left a comment
diesalbla
left a comment
There was a problem hiding this comment.
A few comments.
General changes:
- Replace "palabra clave" (too direct translation of keyword) by "palabra reservada".
- Use the singular form, in preference to the plural form.
Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
Contributor
Author
|
Thanks for the review :) |
ignasi35
reviewed
May 6, 2019
Contributor
ignasi35
left a comment
ignasi35
left a comment
There was a problem hiding this comment.
This looks great! I've left a couple of major comments and a handful of small typo fixes.
Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
ignasi35
approved these changes
May 6, 2019
diesalbla
reviewed
May 6, 2019
diesalbla
approved these changes
May 6, 2019
Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
Contributor
Author
|
Ya le pase el corrector y en contre un par de tildes mas que faltaban. |
Member
|
thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanish translation of Basic scala