New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote compound types tour #742 #988

Merged
merged 2 commits into from Jan 16, 2018

Conversation

Projects
None yet
4 participants
@mghildiy
Contributor

mghildiy commented Jan 13, 2018

No description provided.

@mghildiy

This comment has been minimized.

Show comment
Hide comment
@mghildiy

mghildiy Jan 13, 2018

Contributor

PR 'Rewrote compound types tour #742' can be closed.

Contributor

mghildiy commented Jan 13, 2018

PR 'Rewrote compound types tour #742' can be closed.

Show outdated Hide outdated _tour/self-types.md Outdated
@jvican

I think we're missing some of the changes in https://github.com/scala/docs.scala-lang/pull/742/files, did you rebase from https://github.com/travissarles/scala.github.com/tree/compound-types? If you use hub, you can fetch Travis's branches by doing git fetch travissarles and then doing a rebase for that branch. You can also copy-paste them if you want 😄.

def hasNext: Boolean
def next(): A
}

This comment has been minimized.

@jvican

jvican Jan 14, 2018

Member

Could we remove this extra space? 😄

@jvican

jvican Jan 14, 2018

Member

Could we remove this extra space? 😄

This comment has been minimized.

@mghildiy

mghildiy Jan 15, 2018

Contributor

I assume by extra space you mean line #41.

@mghildiy

mghildiy Jan 15, 2018

Contributor

I assume by extra space you mean line #41.

This comment has been minimized.

@mghildiy

mghildiy Jan 15, 2018

Contributor

or extra space in 38,39.

@mghildiy

mghildiy Jan 15, 2018

Contributor

or extra space in 38,39.

Show outdated Hide outdated _tour/traits.md Outdated
@jvican

Oops, my bad! Just realised those changes were already checked in. They must have been added in another PR. Thank you for your work. Can you address the previous comment and we merge? 🚀

@jvican jvican added the help wanted label Jan 14, 2018

@mghildiy

This comment has been minimized.

Show comment
Hide comment
@mghildiy

mghildiy Jan 14, 2018

Contributor

I have replaced the tab with two spaces.

Contributor

mghildiy commented Jan 14, 2018

I have replaced the tab with two spaces.

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 14, 2018

Member

@mghildiy If you're looking for more, we still need one more contributor in #746 😄.

Member

jvican commented Jan 14, 2018

@mghildiy If you're looking for more, we still need one more contributor in #746 😄.

@mghildiy

This comment has been minimized.

Show comment
Hide comment
@mghildiy

mghildiy Jan 14, 2018

Contributor
Contributor

mghildiy commented Jan 14, 2018

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 14, 2018

Member

Absolutely not, take your time. That's one of the gems that can actually be enlightening to work on if you're new to Scala; a solid understanding of implicits is paramount to become a better Scala programmer..

Member

jvican commented Jan 14, 2018

Absolutely not, take your time. That's one of the gems that can actually be enlightening to work on if you're new to Scala; a solid understanding of implicits is paramount to become a better Scala programmer..

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 14, 2018

Member

Let me know when you've addressed these comments and we merge @mghildiy.

Member

jvican commented Jan 14, 2018

Let me know when you've addressed these comments and we merge @mghildiy.

@mghildiy

This comment has been minimized.

Show comment
Hide comment
@mghildiy

mghildiy Jan 14, 2018

Contributor
Contributor

mghildiy commented Jan 14, 2018

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 15, 2018

Member

It seems you forgot to address my review comments though?

Member

jvican commented Jan 15, 2018

It seems you forgot to address my review comments though?

@mghildiy

This comment has been minimized.

Show comment
Hide comment
@mghildiy

mghildiy Jan 16, 2018

Contributor

Changes done

Contributor

mghildiy commented Jan 16, 2018

Changes done

@jvican jvican merged commit f745d16 into scala:master Jan 16, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details
@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jan 16, 2018

Member

thank you @mghildiy!

Member

SethTisue commented Jan 16, 2018

thank you @mghildiy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment