Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cats from initial libraryDependencies. #14

Merged
merged 3 commits into from Sep 3, 2020

Conversation

mtgto
Copy link
Contributor

@mtgto mtgto commented Nov 12, 2018

This template is used in Getting started with scala and sbt at scala-lang.org.
Cats is unnecessary for beginner.

@kmizu
Copy link

kmizu commented May 10, 2019

@Philippus @travissarles How do you think about this pull request ? I agree with @mtgto 's opinion.

@SethTisue
Copy link
Member

note that https://docs.scala-lang.org/getting-started-sbt-track/getting-started-with-scala-and-sbt-on-the-command-line.html uses scala-parser-combinators as a sample dependency

@SethTisue
Copy link
Member

so I would suggest substituting that, to keep this repo aligned with the web page. note that cats is also mentioned in a subsequent comment, so that needs updating as well

@SethTisue
Copy link
Member

anyone interested in adopting this apparently abandoned PR?

@bjornregnell
Copy link

@SethTisue Is there anything I can do to help getting this merged?

@SethTisue
Copy link
Member

I don't think it's mergeable in its current form, as per my comments above. Happy to merge either this PR, if it is updated, or a replacement PR.

@mtgto
Copy link
Contributor Author

mtgto commented Jul 6, 2020

@SethTisue I update to use scala-parser-combinators instead of cats.

@SethTisue SethTisue merged commit 07285af into scala:master Sep 3, 2020
@SethTisue
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants