Merge branch 'use-spotless-to-build-on-17-and-21' into 'master'

Change the build file to use spotless so the build works with Java 17 and Java 21

See merge request asm/asm!386

Author: forax

build.gradle

@@ -31,7 +31,7 @@ buildscript {
   dependencies { classpath 'org.netbeans.tools:sigtest-maven-plugin:1.5' }
 }
 
-plugins { id 'com.github.sherter.google-java-format' version '0.9' apply false }
+plugins { id 'com.diffplug.spotless' version "6.23.3" apply false }
 plugins { id 'me.champeau.jmh' version '0.6.8' apply false }
 plugins { id 'org.sonarqube' version '4.3.1.3277' apply false }
 
@@ -181,9 +181,14 @@ project(':tools:retrofitter') {
 // All projects are checked with googleJavaFormat, Checkstyle and PMD, 
 // and tested with :asm-test and JUnit.
 subprojects {
-  apply plugin: 'com.github.sherter.google-java-format'
-  googleJavaFormat.toolVersion = '1.18.1'
-  googleJavaFormat.exclude 'src/resources/java/**/*'
+  apply plugin: 'com.diffplug.spotless'
+  spotless {
+    java {
+      target '**/*.java'
+      targetExclude 'src/resources/java/**/*'
+      googleJavaFormat('1.18.1')
+    }
+  }
 
   // Check the coding style with Checkstyle. Fail in case of error or warning.
   apply plugin: 'checkstyle'

tools/retrofitter/src/main/java/org/objectweb/asm/tools/Retrofitter.java

@@ -475,6 +475,12 @@ public MethodVisitor visitMethod(
       return new MethodVisitor(
           api, super.visitMethod(access, name, descriptor, signature, exceptions)) {
 
+        @Override
+        public void visitParameter(final String name, final int access) {
+          // Javac 21 generates a Parameter attribute for the synthetic/mandated parameters.
+          // Remove the Parameter attribute.
+        }
+
         @Override
         public void visitFieldInsn(
             final int opcode, final String owner, final String name, final String descriptor) {