Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.9 #639

Open
eed3si9n opened this issue Jul 11, 2019 · 15 comments

Comments

@eed3si9n
Copy link
Member

commented Jul 11, 2019

Variables to be expanded in this template (or export them in a local terminal, so that you can copy/paste the commands below without replacing anything):

  • SCALA_SHA=cca78e1e18c55e5b0223b9dfa4ac230f7bc6a858
  • DIST_SHA=bc7334d99faf07b83c63066158e256b1606dafe8

Key links:

previously

#582

N weeks before the release

  • Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
  • Triage scala/bug and scala/scala-dev tickets
  • Create next scala/scala milestone, move the magical "Merge to 2.13.x" description to it (so Scabot uses it as default for new PRs)
  • Close the scala/bug milestone, create next milestone, move pending issues
  • Close the scala/scala-dev milestone, create next milestone, move pending issues
  • Check PRs assigned to the milestone, also check WIP
  • Announce expected release date and current nightly "release candidate" (nightly sha-mangled version) at https://scala-ci.typesafe.com/artifactory/scala-integration/ on https://contributors.scala-lang.org/c/announcements

Release announcement / notes

N days before release

  • Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
  • Community build
  • Run scala-collections-laws and evaluate results
    • Rex Kerr (@Ichoran) is the keeper and expert on this
  • Windows Jenkins job
  • Check any merged PRs accidentally assigned to the next milestone in this branch, and re-assign them to this milestone
  • Merge in any older release branch
  • Check module versioning (is everything in versions.properties up to date?)
  • On major release, bump PickleFormat version

Point of no return

Check availability

When everything is on maven central

Modules

Announcements

Afterwards

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

scala/scala PR is down to 4 PRs - https://github.com/scala/scala/milestone/77 /cc @retronym, @diesalbla

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

scala/bug down to 3. https://github.com/scala/bug/milestone/98 two related to Saladoc with "help wanted" tag and one about fresh name.

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

scala/scala PR have all been merged. If all goes well 2.12.9-bin-82e3405 is the current candidate. No further PRs will be committed unless there's a last-minute bug fix.

@SethTisue

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

community build SHA updated, runs on all three JDKs (8/11/12) in progress

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

We might include this - scala/scala#8289

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

ok. New commit SHA is scala/scala@87d43d0.

Scala 2.12.9-bin-87d43d0 is the current candidate.

@SethTisue

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

community builds restarted

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Ran scala-collection-laws:

$ git diff
diff --git a/build.sbt b/build.sbt
index e6cb9f6..a05d13a 100644
--- a/build.sbt
+++ b/build.sbt
@@ -2,4 +2,4 @@ name := "collections-laws"

 version := "0.3.2"

-scalaVersion in ThisBuild := "2.12.2"
+scalaVersion in ThisBuild := "2.12.9-bin-87d43d0"
$ sbt -J-XX:MaxMetaspaceSize=1G -J-Xmx6G "tests/runMain tests.generated.collection.Test_All"
....
[info] Running tests.generated.collection.Test_All
Test lines 86, 206 were not used.
103 collections run against suite of 353 tests (18112 total)
[success] Total time: 473 s, completed Aug 1, 2019 11:56:18 AM
@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Note to self: previous Travis trigger - https://travis-ci.org/scala/scala/builds/542650556/config

before_install: "export SCALA_VER_BASE=2.12.9 SCALA_VER_SUFFIX=\"\""
@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

New commit SHA is scala/scala@cca78e1. This is comment change, so we can reuse the result on Community Build of any other testing.

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

https://travis-ci.org/scala/scala/jobs/567895759 failed because scala/scala now uses before_install. trying before_script..

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Triggering https://travis-ci.org/scala/scala-dist/builds/568002492:

before_install: export version=2.12.9 scala_sha=cca78e1e18c55e5b0223b9dfa4ac230f7bc6a858 mode=archives

https://travis-ci.org/scala/scala-dist/builds/568004143

before_install: export version=2.12.9 scala_sha=cca78e1e18c55e5b0223b9dfa4ac230f7bc6a858 mode=update-api
@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.