Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.10 #649

Closed
SethTisue opened this issue Sep 3, 2019 · 11 comments

Comments

@SethTisue
Copy link
Member

commented Sep 3, 2019

release lead: @SethTisue

Variables to be expanded in this template (or export them in a local terminal, so that you can copy/paste the commands below without replacing anything):

  • SCALA_VER_BASE="2.12.10"
  • SCALA_VER_SUFFIX=""
  • SCALA_SHA=61701c22900f14676fa181500722b64330eb2605
  • DIST_SHA=b0a041bd1b13397dfb56d7b61224ffc5472c9056
  • SCALA_VER="$SCALA_VER_BASE$SCALA_VER_SUFFIX"

Key links:

N weeks before the release

  • Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
  • Triage scala/bug and scala/scala-dev tickets
  • Create next scala/scala milestone, move the magical "Merge to 2.13.x" description to it (so Scabot uses it as default for new PRs)
  • Close the scala/bug milestone, create next milestone, move pending issues
  • Close the scala/scala-dev milestone, create next milestone, move pending issues
  • Check PRs assigned to the milestone, also check WIP
  • Announce expected release date and current nightly "release candidate" (nightly sha-mangled version) at https://scala-ci.typesafe.com/artifactory/scala-integration/ on https://contributors.scala-lang.org/c/announcements

Release announcement / notes

N days before release

  • Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
  • Community build
  • Run scala-collections-laws and evaluate results
    • Rex Kerr (@Ichoran) is the keeper and expert on this
  • Windows Jenkins job
  • Check any merged PRs accidentally assigned to the next milestone in this branch, and re-assign them to this milestone
  • Merge in any older release branch
  • Check module versioning (is everything in versions.properties up to date?)
  • On major release, bump PickleFormat version

Point of no return

Check availability

When everything is on maven central

Modules

Announcements

Afterwards

@SethTisue SethTisue added this to the 2.12.10 milestone Sep 10, 2019

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

the original scala-dist job https://travis-ci.org/scala/scala-dist/builds/583371597 failed with

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::              FAILED DOWNLOADS            ::
[warn] 	:: ^ see resolution messages for details  ^ ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-lang#scala-library;2.10.7!scala-library.jar
[warn] 	:: org.scala-lang#scala-compiler;2.10.7!scala-compiler.jar
[warn] 	:: org.scala-lang#scala-reflect;2.10.7!scala-reflect.jar
[warn] 	:: org.scala-lang#jline;2.10.7!jline.jar
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

no real clue why, but decided to bump scala-dist version from sbt 0.13.17 to 0.13.18 to see if that would help: scala/scala-dist#208

triggered new scala-dist job: https://travis-ci.org/scala/scala-dist/builds/583399629 and it got farther this time

[error] download failed: org.scala-lang#scala-compiler;2.12.10!scala-compiler.jar
[error] unresolved dependency: org.scala-lang#scala-dist;2.12.10: not found

I think this means the Scala JARs have to hit Maven Central first? so I released the staging repos, now waiting for Maven Central sync. watching https://repo1.maven.org/maven2/org/scala-lang/scala-library/2.12.10/

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

JARs are on Maven Central, but when I re-ran https://travis-ci.org/scala/scala-dist/builds/583399629 it hit the 2.10.7 JAR error again, so apparently the 0.13.18 upgrade didn't fix anything, apparently I just need to hit "restart" until it works? :-/

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

I tried removing sonatype-staging from conf/repositories on a wip branch in the scala-dist repo and triggering a build with that: https://travis-ci.org/scala/scala-dist/builds/583412119

I guess the purpose of having sonatype-staging in there is so you can run the scala-dist job even before the Scala JARs have gone to Maven Central, but apparently sonatype-staging isn't operating reliably today; that would account for both kinds of errors I ran into (the missing 2.10.7 JARs and the missing 2.12.10 JARs)

but I don't understand why failures to resolve 2.0.7 from sonatype-staging would matter, why wouldn't it just use maven central instead, conf/repositories has maven central

but anyway the conf/repositories change seems to be working, the job seems to be succeeding. (but it's dinnertime.)

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

job succeeded https://travis-ci.org/scala/scala-dist/builds/583412119

in the scala-dist repo, I attached the v2.12.10 tag to the HEAD of 2.12.x rather than to the commit in my branch, since the branch was merely working around an issue we hope/believe was merely transient

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

https://travis-ci.org/scala/scala-dist-smoketest/builds/583436738 passed (though I had to manually trigger it, it didn't automatically run for some reason)

but both the archives and update-api jobs failed, I don't know why, I'll have to look at it tomorrow:

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

but both the archives and update-api jobs failed, I don't know why,

it seems that the other dists uploaded successfully but the .msi did not

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I'm out of time. I can pick this back up tomorrow, unless another team member gets to it first? once the .msi is in place, then the archives and update-api jobs should be restarted and the website PRs should be merged

@lrytz

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Since I could download the msi on my machine, I just tried re-running the jobs, and they went green. Glitch in the Matrix I guess.

@plokhotnyuk

This comment has been minimized.

Copy link

commented Sep 11, 2019

@SethTisue please use the AND operator in the request to the Maven Search: https://search.maven.org/search?q=g:org.scala-lang%20AND%20v:2.12.10

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

@plokhotnyuk nice catch, thanks for spotting that! fixed

@SethTisue

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

paradise publishing remains, closing anyway since there's a ticket now: scalamacros/paradise#121

@SethTisue SethTisue closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.