Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENSIME proposals (refined after Scala Sphere discussions) #613

Merged
merged 3 commits into from Mar 8, 2017
Merged

ENSIME proposals (refined after Scala Sphere discussions) #613

merged 3 commits into from Mar 8, 2017

Conversation

fommil
Copy link
Contributor

@fommil fommil commented Mar 5, 2017 •
edited

I've taken the liberty of adding the following as advisors (or supervisors in some cases). Please confirm if you're ok with this:

@chipsenkbeil
Copy link

@fommil, don't have permission to check my name, so you'll have to do it for me. ;)

@mlangc
Copy link

mlangc commented Mar 5, 2017

Same for me ;-)

@wpopielarski
Copy link

@fommil I cannot check my name. Btw I would add @sschaef to this list too or you just talked to him about that and he politely refused :)

@fommil
Copy link
Contributor Author

fommil commented Mar 6, 2017

@wpopielarski good point! @sschaef are you happy to advise on the scala-refactoring project? (or the debugging one?)

@kiritsuku
Copy link

sure, but for debugging @wpopielarski is the expert, not me ;)

@fommil
Copy link
Contributor Author

fommil commented Mar 6, 2017

@sschaef yeah, that's what I was thinking. Will add your name to the scala-refactoring one

@mutcianm
Copy link

mutcianm commented Mar 6, 2017

Sure, please check for me as I don't have write access

@fommil
Copy link
Contributor Author

fommil commented Mar 6, 2017

awesome! Cross team collaboration FTW 😄

@fommil
Copy link
Contributor Author

fommil commented Mar 7, 2017

@julienrf this is ready for merge

@julienrf
Copy link
Contributor

julienrf commented Mar 7, 2017

Thanks @fommil, I’ll review this ASAP!

julienrf
julienrf reviewed Mar 8, 2017
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good excepted the weird markup :)

gsoc/2017.md Outdated
method" or "organise imports", but IntelliJ have their own
implementation.

Within the past year the =scala.meta= / scalafix projects have become
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these = around “scala.meta”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org-mode, should be backticks for markdown

@julienrf
Copy link
Contributor

julienrf commented Mar 8, 2017

Thanks!

@julienrf julienrf merged commit 9223256 into scala:master Mar 8, 2017
@propensive
Copy link
Contributor

Should this be "Scala Sphere", not "Scala World"?

@fommil fommil changed the title ENSIME proposals (refined after Scala World discussions) ENSIME proposals (refined after Scala Sphere discussions) Mar 8, 2017
@fommil
Copy link
Contributor Author

fommil commented Mar 8, 2017

@propensive I am always doing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fommil @chipsenkbeil @mlangc @wpopielarski @kiritsuku @mutcianm @julienrf @propensive