Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concrete-immutable-collection-classes.md #486

Merged
merged 1 commit into from Aug 9, 2016

Conversation

AbnerZheng
Copy link
Contributor

常熟->常数

@heathermiller
Copy link
Member

Hi @AbnerZheng thanks for your contribution! In theory this LGTM, I admit my Chinese is a bit rusty :P I don't know of any Chinese-speakers off-hand that I could ask to review this.

Is there someone you could suggest that could have a look?

@SethTisue
Copy link
Member

@apapi, interested in reviewing?

@som-snytt
Copy link
Contributor

It's a clever pun on "constant time" and "the time is ripe". Unfortunately, my spouse, who hates all my puns, is visiting in China this week. But google says, 对我来说很好。

@SethTisue
Copy link
Member

I asked for a reviewer on scala/contributors. If nobody turns up I guess we should just merge

@SethTisue
Copy link
Member

@marky0720 interested in reviewing this?

@som-snytt
Copy link
Contributor

LGTM

OK, my wife is back from China yesterday. She confirms the fix. She also got my pun; or possibly is just being nice about it.

@floating-cat
Copy link

I am a Chinese. This PR is just a typo fix. You can merge this commit without any worries.

@heathermiller
Copy link
Member

Thanks all!

@heathermiller heathermiller merged commit fdd1977 into scala:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants