Skip to content
Browse files

SI-7345 Remove unneeded warning.

According to Hubert, during normal operation we can start buffering
errors in a context with existing errors. So the warning would be noisy.
  • Loading branch information...
1 parent ec33ad0 commit 0ce81c855fc8c12623ae49f1cfa6e1fb255c872a @retronym retronym committed Apr 16, 2013
Showing with 1 addition and 7 deletions.
  1. +1 −7 src/compiler/scala/tools/nsc/typechecker/Contexts.scala
View
8 src/compiler/scala/tools/nsc/typechecker/Contexts.scala
@@ -285,16 +285,10 @@ trait Contexts { self: Analyzer =>
def throwErrors = contextMode.inNone(ReportErrors | BufferErrors)
def setReportErrors(): Unit = set(enable = ReportErrors | AmbiguousErrors, disable = BufferErrors)
- def setBufferErrors(): Unit = {set(enable = BufferErrors, disable = ReportErrors | AmbiguousErrors); warnIfBufferNotClean()}
+ def setBufferErrors(): Unit = set(enable = BufferErrors, disable = ReportErrors | AmbiguousErrors)
def setThrowErrors(): Unit = this(ReportErrors | AmbiguousErrors | BufferErrors) = false
def setAmbiguousErrors(report: Boolean): Unit = this(AmbiguousErrors) = report
- // TODO SI-7345 According to Hubert, this warning will be noisy and is unneccessary.
- private def warnIfBufferNotClean() {
- if (!bufferErrors && hasErrors)
- devWarning("When entering the buffer state, context has to be clean. Current buffer: " + reportBuffer.errors)
- }
-
/** Append the given errors to the report buffer */
def updateBuffer(errors: Traversable[AbsTypeError]) = reportBuffer ++= errors
/** Clear all errors from the report buffer */

0 comments on commit 0ce81c8

Please sign in to comment.
Something went wrong with that request. Please try again.