Skip to content
Browse files

SI-7426 Crash in pickler.

I wonder if the supply of copy-pasted code, and the bugs
which always accompany it, will ever run low. Here we have
a couple hundred lines of tree traversal which appears
roughly identical in structure to a different couple hundred
lines of tree traversal, except one calls methods called
putXXX and the other calls methods called writeXXX.

Except there was one call to writeXXX among all the putXXX
calls. Guess where it was crashing.

This entire file should be expunged.
  • Loading branch information...
1 parent 0a23852 commit df3cae79e7fb40b24b40bcd7a59cbd6b37247e92 @paulp paulp committed Apr 26, 2013
Showing with 3 additions and 1 deletion.
  1. +0 −1 src/compiler/scala/tools/nsc/symtab/classfile/Pickler.scala
  2. +3 −0 test/files/pos/t7426.scala
View
1 src/compiler/scala/tools/nsc/symtab/classfile/Pickler.scala
@@ -293,7 +293,6 @@ abstract class Pickler extends SubComponent {
putTree(definition)
*/
case Template(parents, self, body) =>
- writeNat(parents.length)
putTrees(parents)
putTree(self)
putTrees(body)
View
3 test/files/pos/t7426.scala
@@ -0,0 +1,3 @@
+class foo(x: Any) extends annotation.StaticAnnotation
+
+@foo(new AnyRef { }) trait A

0 comments on commit df3cae7

Please sign in to comment.
Something went wrong with that request. Please try again.