Permalink
Commits on Dec 5, 2012
  1. Merge pull request #1704 from retronym/ticket/6754-2

    Fix for rangepos crasher.
    adriaanm committed Dec 5, 2012
  2. Merge pull request #1712 from jsuereth/fix/osgi-dist

    Fixing OSGi distribution.
    adriaanm committed Dec 5, 2012
  3. Fixing OSGi distribution.

    There was some kind of wierd filesystem issue where ANT would overwrite
    jars or not, depending on timestamps.  It was a non-repeatable failure.
    Rather than overwrite JARs and rely on ANT, let's just spell out the
    non-OSGI bundles.  While I had hoped to avoid hard-coding these,
    it's probably best we've done so.
    jsuereth committed Dec 5, 2012
Commits on Dec 4, 2012
  1. Fix for rangepos crasher.

    wrapClassTagUnapply was generating an unpositioned tree
    which would crash under -Yrangepos.  See SI-6338.
    paulp committed with retronym Oct 2, 2012
Commits on Dec 2, 2012
  1. Merge pull request #1686 from scalamacros/ticket/6685

    Ticket/6685
    xeno-by committed Dec 2, 2012
Commits on Nov 30, 2012
  1. SI-6685 fixes error handling in typedApply

    When MissingClassTagError doesn't lead to an exception, but rather
    silently sets an error, we need to bubble the resulting erroneous tree
    up the responsibility chain instead of mindlessly typechecking this again.
    
    This wasn't an issue before, because as far as I can guess the
    aforementioned error setter was always throwing exceptions in the most
    common usage scenarios (therefore the typecheck-again-fail-again
    vicious loop wasn't triggered).
    xeno-by committed Nov 30, 2012
Commits on Nov 21, 2012
  1. Merge pull request #1656 from jsuereth/fix/remove-future-either-method

    Removing controversial `either` method from Futures API.
    adriaanm committed Nov 21, 2012
  2. Removing controversial `either` method from Futures API.

    * Removes `either` from Future
    * No tests need to change, since this was an untested method.
    jsuereth committed Nov 21, 2012
Commits on Nov 19, 2012
  1. Merge pull request #1607 from retronym/ticket/6640

    SI-6640 Better reporting of deficient classpaths.
    jsuereth committed Nov 19, 2012
  2. Merge pull request #1638 from adriaanm/ticket-6624

    SI-6624 better lookup of case field accessors for case class pattern with complicated type
    jsuereth committed Nov 19, 2012
Commits on Nov 17, 2012
  1. SI-6624 set info of case pattern binder to help find case field acces…

    …sors
    
    sometimes the type checker infers a weird type for a sub-pattern of a case class/extractor pattern
    this confuses the pattern matcher and it can't find the case field accessors for the sub-pattern
    
    use the expected argument type of the extractor corresponding to the case class that we're matching
    as the info for the sub-pattern binder -- this type more readily admits querying its caseFieldAccessors
    adriaanm committed Nov 16, 2012
Commits on Nov 16, 2012
  1. Merge pull request #1636 from paulp/issue/6628

    Fixes SI-6628, Revert "Fix for view isEmpty."
    adriaanm committed Nov 16, 2012
  2. Merge pull request #1616 from retronym/backport/6559

    SI-6559 Fix raw string interpolator: string parts which were after the first argument were still escaped
    adriaanm committed Nov 16, 2012
  3. Merge pull request #1615 from retronym/ticket/6648

    SI-6648 copyAttrs must preserve TypeTree#wasEmpty
    adriaanm committed Nov 16, 2012
  4. Merge pull request #1614 from phaller/issue/correct-promise-signature

    SI-6661 - Remove obsolete implicit parameter of scala.concurrent.promise method
    adriaanm committed Nov 16, 2012
Commits on Nov 15, 2012
  1. Fixes SI-6628, Revert "Fix for view isEmpty."

    This reverts commit caf7eb6.
    
    I don't have a better idea right now than wholesale reversion.
    paulp committed Nov 15, 2012
  2. SI-6661 - Remove obsolete implicit parameter of scala.concurrent.prom…

    …ise method
    
    Clarification of @heathermiller:
    This is an inconsistency introduced after refactoring implicit ExecutionContexts.
    In commit 1dfce90 the implicit ExecutionContexts were removed from everything else in Promise.scala,
    but it appears that method promise was missed in the scala.concurrent package object, which would've made
    sense to remove back then.
    phaller committed Nov 13, 2012
Commits on Nov 14, 2012
  1. Merge pull request #1608 from retronym/ticket/6644

    SI-6644 Account for varargs in extmethod forwarder
    jsuereth committed Nov 14, 2012
  2. Fixes SI-6559 - StringContext not using passed in escape function.

    As reported by Curtis Stanford, with indication of what to fix.  standardInterpolator was not correctly
    calling the passed in process function, so raw strings were not really raw.
    jsuereth committed with retronym Oct 24, 2012
  3. Merge pull request #1601 from cunei/patch-1

    Update tools/epfl-publish
    jsuereth committed Nov 14, 2012
  4. SI-6648 copyAttrs must preserve TypeTree#wasEmpty

    This field tracks whether the type is an inferred
    on, subject to removal in `resetAttrs`, or an explicit
    type, which must remain.
    
    In ae5ff66, `ResetAttrs` was modified to duplicate
    trees, rather than mutate trees in place. But the
    tree copier didn't pass `wasEmpty` on to the new tree,
    which in turn meant that the subsequent typing run
    on the tree would not re-infer the types. If the
    type refers to a local class, e.g. the anonymous
    function in the enclosed test case, the reference
    to the old symbol would persist.
    
    This commit overrides `copyAttrs` in TypeTree to
    copy `wasEmpty`.
    
    We might consider representing this as a tree
    attachment, but this would need to be validated
    for the performance impact.
    retronym committed Nov 11, 2012
Commits on Nov 13, 2012
  1. Merge pull request #1606 from retronym/ticket/6646

    SI-6646 Fix regression in for desugaring.
    adriaanm committed Nov 13, 2012
  2. Fix raw string interpolator: string parts which were after the first …

    …argument were still escaped
    julienrf committed with retronym Aug 9, 2012
  3. Update comment.

    retronym committed Nov 13, 2012
  4. SI-6646 `ident` or Ident is always new binding.

    The previous commit regressed in these cases:
    
        // no withFilter
        for (X <- List("A single ident is always a pattern")) println(X)
        for (`x` <- List("A single ident is always a pattern")) println(`x`)
    
    At the top level of the LHS of a <-, such identifiers represent
    new bindings, not stable identifier patterns.
    retronym committed Nov 13, 2012
  5. SI-6440 Address regressions around MissingRequirementError

     Go back to using globalError to report when a stub's info is referenced,
     and only throw the MissingRequirementError when compilation really
     must abort due to having a StubTermSymbol in a place where a
     StubClassSymbol would have been a better choice.
    
     This situation arises when an entire package is missing from the
     classpath, as was the case in the reported bug.
    
     Adds `StoreReporterDirectTest`, which buffers messages issued
     during compilation for more structured interrogation. Use this
     in two test for manifests -- these tests were using a crude means
     of grepping compiler console output to focus on the relevant output,
     but this approach was insufficient with the new multi-line error
     message emitted as part of this change.
    
     Also used that base test class to add two new tests: one for
     the reported error (package missing), and another for a simpler
     error (class missing). The latter test shows how stub symbols
     allow code to compile if it doesn't the subset of signatures
     in some type that refer to a missing class.
    
     Gave the INFO/WARNING/ERROR members of Reporter sensible
     toString implementations; they inherit from Enumeration#Value
     in an unusual manner (why?) that means the built in toString of
     Enumeration printed `Severity@0`.
    retronym committed Nov 13, 2012
Commits on Nov 10, 2012
  1. Refine the message and triggering of MissingRequirementError.

     - To force a failure of the stub, call a new method `failIfStub`
       rather than `info`.
     - Offer a broader range of potential root causes in the
       error message.
    retronym committed Nov 10, 2012
  2. SI-6640 Better reporting of deficient classpaths.

    In a55788e, StubSymbols were introduced to fail-slow when
    the classpath was deficient. This allowed compilation to
    succeed in cases when one didn't actually use the part of
    class A which referred to some missing class B.
    
    But a few problems were introduced.
    
    Firstly, when the deferred error eventually happened, it was
    signalled with abort(msg), rather than through a thrown
    MissingRequirementError. The latter is desirable, as it doesn't
    lead to printing a stack trace.
    
    Second, the actual error message changed, and no longer
    included the name of the class file that refers to the missing
    class.
    
    Finally, it seems that we can end up with a stub term symbol
    in a situation where a class symbol is desired. An assertion
    in the constructor of ThisType throws trips when calling .isClass,
    before the useful error message from StubSymbol can be emitted.
    
    This commit addresses these points, and rewords the error
    a little to be more accessible. The last point is the most fragile
    in this arrangement, there might be some whack-a-mole
    required to find other places that also need this.
    I don't see a clean solution for this, but am open to suggestions.
    
    We should really build a facility in partest to delete
    specified classfiles between groups in separate compilation
    tests, in order to have tests for this. I'll work on that as a followup.
    
    For now, here's the result of my manual testing:
    
    [info] Set current project to default-821d14 (in build file:/Users/jason/code/scratch1/)
    > compile
    
    [info] Compiling 1 Scala source to /Users/jason/code/scratch1/target/scala-2.10/classes...
    [error]
    [error]      while compiling: /Users/jason/code/scratch1/test.scala
    [error]         during phase: typer
    [error]      library version: version 2.10.0-RC2
    [error]     compiler version: version 2.10.0-RC2
    ...
    [error]   last tree to typer: Ident(SwingWorker)
    [error]               symbol: <none> (flags: )
    [error]    symbol definition: <none>
    [error]        symbol owners:
    [error]       context owners: object Test -> package <empty>
     ...
    [error] uncaught exception during compilation: java.lang.AssertionError
    [trace] Stack trace suppressed: run last compile:compile for the full output.
    [error] (compile:compile) java.lang.AssertionError: assertion failed: value actors
    [error] Total time: 2 s, completed Nov 10, 2012 3:18:34 PM
    >
    > set scalaHome := Some(file("/Users/jason/code/scala/build/pack"))
    [info] Defining *:scala-home
    [info] The new value will be used by no settings or tasks.
    [info] Reapplying settings...
    [info] Set current project to default-821d14 (in build file:/Users/jason/code/scratch1/)
    ^[compile
    [info] Compiling 1 Scala source to /Users/jason/code/scratch1/target/scala-2.10/classes...
    [error] /Users/jason/code/scratch1/test.scala:4: A signature in SwingWorker.class refers to term actors in package scala which is missing from the classpath.
    [error] object Test extends SwingWorker
    [error]                     ^
    [error] one error found
    [error] (compile:compile) Compilation failed
    [error] Total time: 2 s, completed Nov 10, 2012 3:18:45 PM
    retronym committed Nov 10, 2012
  3. SI-6644 Account for varargs in extmethod forwarder

    Which sounded difficult, so instead I offshored the work
    to the friendly republic of TreeGen.
    retronym committed Nov 10, 2012
  4. SI-6646 Fix regression in for desugaring.

    The early check in the parser of pattern irrefutability,
    added in c82ecab, failed to consider InitCaps and
    `backquoted` identifiers.
    retronym committed Nov 10, 2012
Commits on Nov 9, 2012
  1. Update tools/epfl-publish

    Currently, during each Scala nightly build, the epfl-publish script rsyncs the resulting dists/archives to the repository machine (chara).
    
    Now, as a result of a change introduced a while back, dists/archives/ now also contains a symbolic link, created at the end of the build when the targets "pack-archives.latest.*" are invoked (in src/build/pack.xml). That was introduced in:
    
    scala/scala@506bcfe
    scala/scala@cb99853
    
    This link, created in dists/archives/, is copied over as-is at the end of the rsync to chara by epfl-publish. On chara, however, the link points to an invalid target (the path is absolute).
    
    Separately, the repository directory on chara is rsync'd every 30 minutes over to the machine that serves www.scala-lang.org, via cron. Rsynch finds that the link target does not exist, and generates an email with the crontab log, which is then duly sent to a system mailbox. Every 30 minutes. Since March. Needless to say, the mailbox is pretty large by now.
    
    The fix is trivial, but this needs to be included in all the branches that are tested during the nightly. Since RC2 has just been cut, and the code frozen, I'm not sure how this change can be included without disruption; therefore, I'll just send a pull request on 2.10.0-wip, and let Josh/Paul take the appropriate steps.
    cunei committed Nov 9, 2012
Commits on Nov 5, 2012
  1. Merge pull request #1569 from jsuereth/fix/osgi-manifests

    Fixing issue where OSGi bundles weren't getting used for distribution.
    adriaanm committed Nov 5, 2012
Commits on Nov 4, 2012
  1. Merge pull request #1566 from densh/topic/asSeenFrom-example

    Fixes example in Type.asSeenFrom
    jsuereth committed Nov 4, 2012
  2. Merge pull request #1559 from heathermiller/copyright-update

    Updated copyright dates throughout compiler and stdlib for upcoming release
    jsuereth committed Nov 4, 2012