Skip to content
Commits on Nov 3, 2012
  1. @densh

    Fixes example in Type.asSeenFrom

    It was written in some form of non-executable pseudo-code before and
    that might be quite confusing for people who are not familiar with scala
    reflection.
    densh committed Nov 2, 2012
  2. @jsuereth

    Merge pull request #1562 from paulp/issue/6600

    Fix for SI-6600, regression with ScalaNumber.
    jsuereth committed Nov 2, 2012
  3. @adriaanm

    Merge pull request #1561 from gkossakowski/ticket/6562

    SI-6562 Fix crash with class nested in @inline method
    adriaanm committed Nov 2, 2012
Commits on Nov 2, 2012
  1. @paulp

    Fix for SI-6600, regression with ScalaNumber.

    Not much in the end; I divided ScalaNumericConversions
    into two traits such that the ScalaNumericAnyConversions can
    be used in value classes, and ScalaNumericConversions can
    override methods in ScalaNumber (since one trait cannot do
    both those things.)
    
    The fact that ScalaNumber is privileged for equality but a) extends
    java.lang.Number and therefore b) cannot be a value class is something
    we will want to revisit real soon.
    paulp committed Nov 2, 2012
  2. @retronym @gkossakowski

    SI-6562 Fix crash with class nested in @inline method

    e6b4204 moved access widenings from ExplicitOuter to
    SuperAccessors to reflect them in pickled signatures so
    that the inliner can take advantage of them under separate
    compilation.
    
    The followup discussion [1] determined that this wasn't
    the right solution: while it enabled new separate compilation
    inlinings, it failed to widen access of outer pointers and
    hence prevented certain inlinings.
    
    A better solution was proposed: modify the inliner to know
    that access widening is guaranteed to have happened in
    ExplicitOuter for any field accessed by an @inline-d method
    body, rather than relying solely on the pickled types.
    
    But this hasn't happened yet. In the meantime 07f9429 / #1121
    reinstated the access widening to SuperAccessors, but took a
    slightly different approach, using `Symbol#enclMethod` rather
    than `closestEnclMethod`. That deviation triggers SI-6562.
    
    This commit goes back to `closestEnclMethod`.
    
    [1] https://groups.google.com/forum/#!topic/scala-internals/iPkMCygzws4
    retronym committed with gkossakowski Oct 25, 2012
  3. @jsuereth

    Merge pull request #1558 from heathermiller/doc/reflection-errata

    API docs: reflection fixes, AnyVal/Any documentation additions, errata
    jsuereth committed Nov 2, 2012
  4. @heathermiller
  5. @heathermiller
  6. @heathermiller
  7. @heathermiller
  8. @heathermiller

    Labeling scala.reflect and scala.reflect.macros experimental in the A…

    …PI docs
    
    - Added the labels across scala.reflect and scala.reflect.macros
    - Added the styling in template.css that is used by all labels
    heathermiller committed Nov 1, 2012
  9. @heathermiller
  10. @hubertp @heathermiller

    Remove implementation details from Position (they are still under ref…

    …lection.internal). It probably needs more cleanup of the api wrt to ranges etc but let's leave it for later
    hubertp committed with heathermiller Oct 30, 2012
  11. @heathermiller

    SI-6399 Adds API docs for Any and AnyVal

    - Updates AnyVal docs to address value classes.
    - Updates Any docs to address universal traits.
    heathermiller committed Nov 1, 2012
Commits on Nov 1, 2012
  1. @adriaanm

    Merge pull request #1526 from paulp/value-classes/6534-equals

    New take on SI-6534, value classes.
    adriaanm committed Nov 1, 2012
  2. @adriaanm

    Merge pull request #1540 from odersky/ticket/6500

    Fixes SI-6500 by making erasure more regular.
    adriaanm committed Nov 1, 2012
  3. @adriaanm

    Merge pull request #1542 from adriaanm/odersky-ticket/6556v2

    SI-6556 no assert for surprising ctor result type
    adriaanm committed Nov 1, 2012
  4. @jsuereth

    Merge pull request #1541 from jsuereth/fix/SI-6577-actors-migration

    SI-6577 Make actors-migration an external module
    jsuereth committed Nov 1, 2012
  5. @jsuereth

    Removing actors-migration from main repository so it can live on else…

    …where.
    
    * Removes actors-migration hooks from partest
    * Removes actors-migration code
    * removes actors-migration tests
    * removes actors-migration distribution packaging.
    jsuereth committed Oct 30, 2012
  6. @jsuereth
Commits on Oct 31, 2012
  1. @jsuereth

    Merge pull request #1543 from adriaanm/paulp-add-synthetics-once

    SI-6578 Harden against synthetics being added more than once.
    jsuereth committed Oct 31, 2012
  2. @jsuereth

    Merge pull request #1536 from vjovanov/issues/SI-6581

    SI-6581 fixed by inlining `Actor.self`.
    jsuereth committed Oct 31, 2012
  3. @jsuereth

    Merge pull request #1532 from hubertp/2.10.0-wip-issue/5031

    Fixes SI-5031 for separate compilation scenario.
    jsuereth committed Oct 31, 2012
Commits on Oct 30, 2012
  1. @adriaanm

    Merge pull request #1530 from retronym/ticket/6575-2

    SI-6575 Plug inference leak of AbstractPartialFunction
    adriaanm committed Oct 30, 2012
  2. @paulp @adriaanm

    SI-6578 Harden against synthetics being added more than once.

    Don't add synthetic methods if they already contain synthetic
    methods from the set we're about to add.
    paulp committed with adriaanm Oct 23, 2012
  3. @odersky @adriaanm

    SI-6556 no assert for surprising ctor result type

    Previous fix to value classes uncovered some questionable cases in the backend where result types of constructor signatures are surprising. It's not a big deal because these types will be ignored afterwards anyway. But
    the method uncovered some questionable situations which we should follow up on. However, breaking 2.9 code because of this is way too harsh. That's why the asserts were converted to warnings.
    
    review by @paulp, @adriaanm
    odersky committed with adriaanm Oct 30, 2012
  4. @jsuereth

    Removing actors-migration from main repository so it can live on else…

    …where.
    
    * Removes actors-migration hooks from partest
    * Removes actors-migration code
    * removes actors-migration tests
    * removes actors-migration distribution packaging.
    jsuereth committed Oct 30, 2012
  5. @odersky

    Fixes SI-6500 by making erasure more regular.

    With the introduction of value classes, erasure uses specialErasure where a value class C with underlying type T is unboxed to an ErasedValueType. ErasedValue types are eliminated on phase later, in post-erasure. This was done everywhere, except in the parameter types of bridge methods. That was a mistale, because that way  bridge methods could not do the boxing/unboxing logic triggered by ErasedValueTypes.
    
    Note: there is one remaining use of erasure (not specialErasure) in Erasure.scala. I put in a comment why that is OK.
    odersky committed Oct 30, 2012
  6. @paulp

    Modification to SI-6534 patch.

    Only exclude hashCode and equals from being overridden in
    value classes, not other synthetics which may turn up such
    as case class methods.
    paulp committed Oct 30, 2012
  7. @vjovanov

    SI-6581 fixed by inlining `Actor.self`.

    This avoids the necessary type cast that was preventing leakage of internal migration classes.
    
    Review by @phaller
    vjovanov committed Oct 30, 2012
Commits on Oct 29, 2012
  1. @retronym

    Use Typed rather than .setType

    In response to pull request feedback.
    retronym committed Oct 29, 2012
Commits on Oct 28, 2012
  1. @hubertp

    Fixes SI-5031 for separate compilation scenario.

    When you have a conflicting member in package object and normal package that share the same namespace we remove the latter ClassSymbol from the scope. Now, this has an unpleasant consequence that companionClass/companionModule/companionSymbol no longer work correctly as they rely on finding the correspondent symbol using decls of the owner.
    This fixes the problem of SI-5031 for separate compilation. Why the above change matters for finding foo.bar.Foo? Because when parsing the class we needed information about the static module (and we have the correct module symbol when completing the info). It's just that 043ce6d relied on no longer valid assumptions. So we were getting NoSymbol and sym.exist was failing.
    
    Obviously a more complete solution would be better if we didn't rely on the scope but that's too big to change for 2.10.0.
    hubertp committed Oct 28, 2012
  2. @retronym

    Wider use and a new variant of typedPos.

    It's safe to replace `localTyper.typed(atPos(pos)(tree))` with
    `localTyper.typedPos(pos)(tree)` given that we're all in the
    same cake and we'll get to the same `atPos`.
    retronym committed Oct 28, 2012
  3. @retronym

    SI-6575 Plug inference leak of AbstractPartialFun

    Usually this isn't needed, as partial functions can only be
    defined with an expected type. But if that expected type is
    and inherited method return type, the actual type of the partial
    function literal is used, and the implementation detail of
    `AbstractPartialFunction[A, B] with Serializable` leaks out.
    
    After this change, the inferred types match those from
    Scala 2.9.2.
    
    ticket/6575 ~/code/scala scalac29 -Xprint:typer test/files/pos/t6575a.scala | grep def > 29.txt
    ticket/6575 ~/code/scala squalac -Xprint:typer test/files/pos/t6575a.scala | grep def > 210.txt
    ticket/6575 ~/code/scala diff -u 29.txt 210.txt
    --- 29.txt	2012-10-28 13:51:07.000000000 +0100
    +++ 210.txt	2012-10-28 13:51:20.000000000 +0100
    @@ -1,7 +1,16 @@
         def foo: PartialFunction[Int,Int]
         def /*Y*/$init$(): Unit = {
    -    absoverride def foo: PartialFunction[Int,Int] = ((x0$1: Int) => x0$1 match {
    +    absoverride def foo: PartialFunction[Int,Int] = {
    +        def <init>(): anonymous class $anonfun = {
    +        final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
    +        final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
         def /*Z*/$init$(): Unit = {
    -    absoverride def foo: PartialFunction[Int,Int] = ((x0$2: Int) => x0$2 match {
    +    absoverride def foo: PartialFunction[Int,Int] = {
    +        def <init>(): anonymous class $anonfun = {
    +        final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
    +        final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
         def /*Comb*/$init$(): Unit = {
    -    absoverride def foo: PartialFunction[Int,Int] = ((x0$3: Int) => x0$3 match {
    +    absoverride def foo: PartialFunction[Int,Int] = {
    +        def <init>(): anonymous class $anonfun = {
    +        final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
    +        final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
    retronym committed Oct 28, 2012
Commits on Oct 24, 2012
  1. @paulp

    New take on SI-6534, value classes.

    Don't prohibit equals and hashCode in universal traits;
    instead, always override them in value classes.
    paulp committed Oct 24, 2012
Something went wrong with that request. Please try again.