Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVERTED: Args files are 1 arg per line, fix -Vprint-args - #10123

Merged
merged 2 commits into from Aug 31, 2022

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Aug 28, 2022

Previously, lines of @my.args files were concatenated and parsed, but this is not desirable.

This commit takes an args file as one arg per line. This makes spaces unambiguous:

--classpath
C:\Program Files\Java\bin

This change also makes backslashes unambiguous. In the shell, call them bashslackers.

Also trim lines and remove empty lines.

arg # comment should not introduce space after arg
# comment line should be removed

Not sure if anyone exploits these advanced arg file features.

Also fix processing of -Vprint-args - where - is a legal option setting.

Fixes scala/scala-dev#814

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Aug 28, 2022
@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.9 Aug 28, 2022
@SethTisue SethTisue self-assigned this Aug 28, 2022
@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label Aug 28, 2022
@SethTisue SethTisue merged commit af56abc into scala:2.13.x Aug 31, 2022
4 checks passed
@SethTisue SethTisue changed the title Args files are 1 arg per line, fix -Vprint-args - REVERTED: Args files are 1 arg per line, fix -Vprint-args - Sep 1, 2022
@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label Sep 1, 2022
@SethTisue SethTisue removed this from the 2.13.9 milestone Sep 1, 2022
@SethTisue
Copy link
Member

SethTisue commented Sep 1, 2022

reverted (at least until after 2.13.9 is out) by #10128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants