Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SI-6488: Fix for race with open I/O fds #1484

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

Unless the I/O threads for error and output are closed prior to Process.destroy() there is a potential race condition that ends in the I/O threads raising an IOException.

Member

jsuereth commented Oct 10, 2012

Three questions:

(1) have you signed the scala cla?
(2) can you target this at 2.10.x
(3) can you include a small test case

The code looks good, but I need that test case to prevent regression.

Owner

adriaanm commented Oct 19, 2012

closing for lack of progress

@possiblywrong, please re-open or resubmit after addressing the review comments

@adriaanm adriaanm closed this Oct 19, 2012

(1) Signed and submitted, it was delayed going through my employer's legal process, hence the lack of apparent progress.
(2) Can do, but should I resubmit the patch & test against master or 2.10.x? or do you mean change the fix version in SI-6488?
(3) Someone needs to give me a pointer to where in the mass of tests I should best put a test case. It's really not that obvious.

@adriaanm adriaanm reopened this Oct 23, 2012

Owner

adriaanm commented Oct 23, 2012

Thanks! Resubmitting against the 2.10.x branch would be perfect.
Tests that need to run go under test/files/run -- you need a t6488.scala with a Test object that has a main method,
and t6488.check (the latter contains the expected output of running the former).

The original repro for the issue is not a good test as it take 10s. We have a lot of tests to run, so each should be as fast as possible (and deterministic of course).

@jsuereth jsuereth closed this Oct 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment