Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixing issue where OSGi bundles weren't getting used for distribution. #1569

Merged
merged 1 commit into from Nov 5, 2012

Conversation

Projects
None yet
4 participants
Member

jsuereth commented Nov 4, 2012

Review by @lrytz or anyone interested before 2.10.0-RC2

@viktorklang viktorklang commented on the diff Nov 4, 2012

build.xml
@@ -2663,7 +2663,8 @@ DISTRIBUTION
<attribute name="name" />
<sequential>
<copy file="${build-osgi.dir}/org.scala-lang.plugins.@{name}.jar"
- tofile="${dist.dir}/misc/scala-devel/plugins/@{name}.jar"/>
+ tofile="${dist.dir}/misc/scala-devel/plugins/@{name}.jar"
+ overwrite="yes"/>
@viktorklang

viktorklang Nov 4, 2012

Contributor

wow, super intuitive!

Member

jsuereth commented Nov 5, 2012

Yo @adriaanm can I get a LGTM, so I can cut a RC2?

Owner

adriaanm commented Nov 5, 2012

LGTM

adriaanm added a commit that referenced this pull request Nov 5, 2012

Merge pull request #1569 from jsuereth/fix/osgi-manifests
Fixing issue where OSGi bundles weren't getting used for distribution.

@adriaanm adriaanm merged commit 8b59843 into scala:2.10.0-wip Nov 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment