Fix for SI-6663 #1619
Closed
Fix for SI-6663 #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mkInvoke to handle selectDynamic calls of the form new C.foo[T].xyz (where C extends Dynamic) Without this patch, the type parameter was silently ignored, and possibly inferred to a different. This patch fixes mkInvoke to handle that case, where the ctxTree has the form Select(TypeApply(fun, targs), nme)
Fix mkInvoke to handle selectDynamic calls of the form new C.foo[T].xyz :U (where C extends Dynamic) Without this patch, the type parameter T was silently ignored, and possibly inferred to a different. This patch fixes mkInvoke to handle that case, where the ctxTree has the form Typed(...)
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/940/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/940/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1647/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1647/ |
|
I think this should target 2.10.x |
|
Oops sorry - didn't mean to click on 'close'. @jsuereth: anything I can do regarding 2.10.x? Check if patch applies cleanly? Switch pull request to different branch? |
|
Yes, please close this PR and reopen against 2.10.x. Review by @namin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes the bug reported in SI-6663, the second one another similar case as noted in a comment on that bug report.
I'd guess that there are other possible contents of cxTree not yet handled. Is there a better way to fix this than to add all such cases manually to mkInvoke?