Removing controversial `either` method from Futures API. #1656

Merged
merged 1 commit into from Nov 21, 2012

Conversation

Projects
None yet
5 participants
Member

jsuereth commented Nov 21, 2012

  • Removes either from Future
  • No tests need to change, since this was an untested method.

Review by @phaller

Removing controversial `either` method from Futures API.
* Removes `either` from Future
* No tests need to change, since this was an untested method.

@phaller phaller referenced this pull request in scala/docs.scala-lang Nov 21, 2012

Merged

Remove paragraph on method 'either' #133

Contributor

phaller commented Nov 21, 2012

LGTM

Contributor

phaller commented Nov 21, 2012

I also submitted a corresponding update to the futures overview on the doc site (see above)

Owner

adriaanm commented Nov 21, 2012

I'm fine merging this, but it would be good to know why this is controversial (does it conflict with a method that is added on through implicits?) so that people who might be affected unbeknownst to us at least understand the change.

Owner

heathermiller commented Nov 21, 2012

This has been long-discussed in this thread:
https://groups.google.com/forum/?fromgroups=#!topic/scala-sips/VRlDgX4yFKE

Here, the consensus was to remove it for now. Later, e.g. in 2.10.1, when some consensus is arrived at regarding naming and semantics of this method, we can add it without breaking binary compatibility.

Owner

adriaanm commented Nov 21, 2012

Thanks for the link, Heather. Sorry I missed that discussion.

adriaanm added a commit that referenced this pull request Nov 21, 2012

Merge pull request #1656 from jsuereth/fix/remove-future-either-method
Removing controversial `either` method from Futures API.

@adriaanm adriaanm merged commit 57b91c5 into scala:2.10.0-wip Nov 21, 2012

Contributor

phaller commented Nov 21, 2012

Great. Thanks, Heather and Adriaan.

VladUreche pushed a commit to VladUreche/scala.github.com that referenced this pull request Dec 24, 2013

Remove paragraph on method 'either'
Method 'either' of the 'Future' trait will not be part of Scala 2.10.0, therefore
it should not be mentioned in the futures overview article.

The corresponding pull request:
scala/scala#1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment