Skip to content

Fixing OSGi distribution. #1712

Merged
merged 1 commit into from Dec 5, 2012

2 participants

@jsuereth
The Scala Programming Language member
jsuereth commented Dec 5, 2012

Apparently you have to resort to all manners of awesome in ant. Probably better to
filter in what you awnt to copy rather than overwrite. So far ths works.

Review by @lrytz or @adriaanm

@adriaanm
The Scala Programming Language member
adriaanm commented Dec 5, 2012

could you comment on why only these files are needed and not some of the others I see in the lib directory of an older distribution?

@jsuereth
The Scala Programming Language member
jsuereth commented Dec 5, 2012

It's a matter of where they come from. If you look at the context, you can see the filtered ones are non-osgi while the osgi bundles are copied from a different location.

@jsuereth jsuereth Fixing OSGi distribution.
There was some kind of wierd filesystem issue where ANT would overwrite
jars or not, depending on timestamps.  It was a non-repeatable failure.
Rather than overwrite JARs and rely on ANT, let's just spell out the
non-OSGI bundles.  While I had hoped to avoid hard-coding these,
it's probably best we've done so.
e791a92
@jsuereth
The Scala Programming Language member
jsuereth commented Dec 5, 2012

See newly improved comment.

@adriaanm
The Scala Programming Language member
adriaanm commented Dec 5, 2012

LGTM

@adriaanm adriaanm merged commit e15d8fc into scala:2.10.0-wip Dec 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.