New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-7469 Remove @deprecated scala.util.logging #2543

Merged
merged 1 commit into from May 16, 2013

Conversation

Projects
None yet
3 participants
@soc
Copy link
Member

soc commented May 16, 2013

No description provided.

@soc

This comment has been minimized.

Copy link
Member Author

soc commented May 16, 2013

Review by @paulp/@retronym, please.
This PR takes the feedback of #2522 into account.

@retronym

This comment has been minimized.

Copy link
Member

retronym commented May 16, 2013

LGTM

@soc

This comment has been minimized.

Copy link
Member Author

soc commented May 16, 2013

@retronym Missed some tests, could you have a look again?

  • 1 test was useless after the classes were removed
  • 2 tests had useless imports
@retronym

This comment has been minimized.

Copy link
Member

retronym commented May 16, 2013

Thanks for letting me know; still LGTM. (even better!)

@soc

This comment has been minimized.

Copy link
Member Author

soc commented May 16, 2013

Oh, also important: I added an @deprecated annotation to src/library/scala/xml/factory/LoggedNodeFactory.scala.

@adriaanm

This comment has been minimized.

Copy link
Member

adriaanm commented May 16, 2013

Awesome work, thanks!

adriaanm added a commit that referenced this pull request May 16, 2013

Merge pull request #2543 from soc/SI-7469-logging
SI-7469 Remove @deprecated scala.util.logging

@adriaanm adriaanm merged commit 173a7a5 into scala:master May 16, 2013

1 check passed

default pr-checkin-per-commit Took 41 min.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment